minor #5736 Remove references to PHP 5.6 (kubawerlos, keradus)

This PR was squashed before being merged into the 3.0 branch. Discussion ---------- Remove references to PHP 5.6 Commits ------- d4ff118 Remove references to PHP 5.6
PHP-CS-Fixer · Aug 2, 2021 · 8055779 · 8055779
2 parents ec10484 + d4ff118
commit 8055779
Show file tree

Hide file tree

Showing 7 changed files with 24 additions and 15 deletions.
diff --git a/doc/installation.rst b/doc/installation.rst
@@ -5,7 +5,7 @@ Installation
 Requirements
 ------------
 
-PHP needs to be a minimum version of PHP 5.6.0.
+PHP needs to be a minimum version of PHP 7.1.3.
 
 Installation
 ------------

diff --git a/src/Fixer/Basic/EncodingFixer.php b/src/Fixer/Basic/EncodingFixer.php
@@ -83,13 +83,8 @@ protected function applyFix(\SplFileInfo $file, Tokens $tokens): void
         $content = $tokens[0]->getContent();
 
         if (0 === strncmp($content, $this->BOM, 3)) {
-            /** @var false|string $newContent until support for PHP 5.6 is dropped */
             $newContent = substr($content, 3);
 
-            if (false === $newContent) {
-                $newContent = ''; // substr returns false rather than an empty string when starting at the end
-            }
-
             if ('' === $newContent) {
                 $tokens->clearAt(0);
             } else {

diff --git a/tests/AutoReview/DocumentationTest.php b/tests/AutoReview/DocumentationTest.php
@@ -160,6 +160,23 @@ public function testRuleSetsDocumentationDirectoryHasNoExtraFiles(): void
         );
     }
 
+    public function testInstallationDocHasCorrectMinimumVersion(): void
+    {
+        $composerJsonContent = file_get_contents(__DIR__.'/../../composer.json');
+        $composerJson = json_decode($composerJsonContent, true);
+        $phpVersion = $composerJson['require']['php'];
+        $minimumVersion = ltrim(substr($phpVersion, 0, strpos($phpVersion, ' ')), '^');
+
+        $minimumVersionInformation = sprintf('PHP needs to be a minimum version of PHP %s.', $minimumVersion);
+        $installationDocPath = realpath(__DIR__.'/../../doc/installation.rst');
+
+        static::assertStringContainsString(
+            $minimumVersionInformation,
+            file_get_contents($installationDocPath),
+            sprintf('Files %s needs to contain information "%s"', $installationDocPath, $minimumVersionInformation)
+        );
+    }
+
     private static function assertFileEqualsString(string $expectedString, string $actualFilePath, string $message = ''): void
     {
         static::assertFileExists($actualFilePath, $message);

diff --git a/tests/Fixer/Alias/ArrayPushFixerTest.php b/tests/Fixer/Alias/ArrayPushFixerTest.php
@@ -152,12 +152,12 @@ public function provideFixCases()
         ];
 
         yield [
-            '<?php $a->$c[] = $b;', // invalid on PHP5.6
+            '<?php $a->$c[] = $b;',
             '<?php array_push($a->$c, $b);',
         ];
 
         yield [
-            '<?php $a->$c[1]->$d{$a--}->$a[7][] = $b;', // invalid on PHP5.6
+            '<?php $a->$c[1]->$d{$a--}->$a[7][] = $b;',
             '<?php array_push($a->$c[1]->$d{$a--}->$a[7], $b);',
         ];
 

diff --git a/tests/Fixer/Alias/SetTypeToCastFixerTest.php b/tests/Fixer/Alias/SetTypeToCastFixerTest.php
@@ -145,15 +145,15 @@ public function provideFixCases()
             // do not fix cases
             'first argument is not a variable' => [
                 '<?php
-                    namespace A\B;             // needed to keep the linter happy on PHP5.6
+                    namespace A\B;             // comment
                     function settype($a, $b){} // "
 
                     settype(1, "double");
                 ',
             ],
             'first argument is variable followed by operation' => [
                 '<?php
-                    namespace A\B;                // needed to keep the linter happy on PHP5.6
+                    namespace A\B;                // comment
                     function settype($a, $b){}    // "
 
                     settype($foo + 1, "integer"); // function must be overridden, so do not fix it
@@ -202,7 +202,7 @@ function settype($a, $b){}    // "
             ],
             'wrapped statements, not-fixable, even after removing the useless parenthesis brace' => [
                 '<?php
-                    namespace A\B;                // needed to keep the linter happy on PHP5.6
+                    namespace A\B;                // comment
                     function settype($a, $b){}    // "
 
                     settype($foo1, (("integer")."1"));

diff --git a/tests/Fixtures/Integration/misc/meta_insert_64566_tokens.test b/tests/Fixtures/Integration/misc/meta_insert_64566_tokens.test
@@ -1,9 +1,6 @@
 --TEST--
 Test of super huge file that would require 64566 tokens to be inserted! Basically, this tests Tokens::insertSlices, without which this test would take few hours to execute.
-Note: requiring PHP 7+ just to skip PHP 5.6 with memory issues for this huge test case.
 --RULESET--
 {
     "whitespace_after_comma_in_array": true
 }
---REQUIREMENTS--
-{"php": 70000}
diff --git a/tests/Smoke/CiIntegrationTest.php b/tests/Smoke/CiIntegrationTest.php
@@ -143,7 +143,7 @@ public function testIntegration(
         $optionalDeprecatedVersionWarning = 'You are running PHP CS Fixer v3, which is not maintained anymore. Please update to v4.
 ';
 
-        $optionalIncompatibilityWarning = 'PHP needs to be a minimum version of PHP 5.6.0 and maximum version of PHP 7.4.*.
+        $optionalIncompatibilityWarning = 'PHP needs to be a minimum version of PHP 7.1.3 and maximum version of PHP 8.0.*.
 Current PHP version: '.PHP_VERSION.'.
 Ignoring environment requirements because `PHP_CS_FIXER_IGNORE_ENV` is set. Execution may be unstable.
 ';