Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Tags #71

Closed
MikeLundahl opened this issue Sep 11, 2024 · 4 comments
Closed

Include Tags #71

MikeLundahl opened this issue Sep 11, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@MikeLundahl
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe.
Currently, the webhook does not include the tags.

Describe the solution you'd like

  • Include the tags in the text, perhaps right after or under the Discussion title
  • Have a setting to include the tags (either a global setting for all webhooks, or a per webhook switch)

A detailed description of your proposed solution. Include:
Here's a mockup of how it potentially could look like (Slack)
image

I'd be happy to look at this if it sounds interesting to have implemented.

@MikeLundahl MikeLundahl added the enhancement New feature or request label Sep 11, 2024
@MikeLundahl
Copy link
Contributor Author

As a follow-up question, what would be best for a solution like this: have a "include tags" switch globally for the entire extension or have the setting within each webhook?

@DavideIadeluca
Copy link
Member

Thanks @MikeLundahl for your feature request – This definitely is an interesting prospect. I think an opt-in toggle for each webhook would be the best solution here to ensure we are not breaking existing integrations. I Would be happy to review the PR.

@MikeLundahl
Copy link
Contributor Author

I almost got a solution ready for a PR. I'm only having technical issues with Microsoft Teams.

Yesterday, Microsoft wouldn't let me create a new premium account, and today, I managed to create an account, but they don't give me access to Teams, and the Admin settings only result in a black screen with an error message. I've reached out to support.

As soon as I get that resolved, a PR should follow soon after.

@MikeLundahl
Copy link
Contributor Author

MikeLundahl commented Sep 13, 2024

@DavideIadeluca Just created a PR. Have a look. I excluded the setting from "microsoft Teams" as I'm still having issues with it and can't test it until it's resolved. But it functions for Discord and Slack.

#72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants