Fix the nonce generated for the plugin activation link in the upgrade… #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swashata
reviewed
Jul 23, 2025
Contributor
swashata
left a comment
swashata
left a comment
There was a problem hiding this comment.
Please see my question, thanks
| $this->do_action( 'after_free_version_reactivation' ); | ||
|
|
||
| if ( $this->is_paying() && ! $this->is_premium() ) { | ||
| $this->add_complete_upgrade_instructions_notice( |
Contributor
There was a problem hiding this comment.
Can we just skip this notice altogether if !is_admin? Do we have a reason to believe admin_init can get called outisde is_admin()?
fajardoleo
force-pushed
the
feature/leo/fix-admin-notice-activation-link-nonce
branch
3 times, most recently
from
fce2a53 to
3e06b5a
Compare
swashata
approved these changes
Aug 12, 2025
Contributor
swashata
left a comment
swashata
left a comment
There was a problem hiding this comment.
LGTM. Please ask @DanieleAlessandra to test it 🙏
Contributor
|
@fajardoleo please also fix the linting issue Looks like an unintended trailing comma. |
swashata
requested changes
Aug 12, 2025
Contributor
swashata
left a comment
swashata
left a comment
There was a problem hiding this comment.
Code looks good. Just has a lint issue for PHP 7.0 (no trailing comma)
… instructions admin notice.
fajardoleo
force-pushed
the
feature/leo/fix-admin-notice-activation-link-nonce
branch
from
3e06b5a to
6681019
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… instructions admin notice.