Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Information for Download Progress #12

Open
anthony-S93 opened this issue Dec 17, 2022 · 0 comments
Open

Incorrect Information for Download Progress #12

anthony-S93 opened this issue Dec 17, 2022 · 0 comments

Comments

@anthony-S93
Copy link

anthony-S93 commented Dec 17, 2022

For large downloads, the value displayed in the "progress" column is inaccurate. Let me explain this via an example. Suppose I intend to download a video that is 3 GiB in size.

When the download first begins, the string in the "progress" column may look something like this 0.0% (0 MiB/350 MiB). Immediately, we can tell that this value is inaccurate because the actual size of the video is 3GiB. As the download progresses, the values update normally, although they are still inaccurate. For instance,

0.3% (1 MiB/350 MiB)
14% (50 MiB/350 MiB)

etc. etc.

Note that the percentage values are still calculated correctly, just that the total size of the video is wrong. When the percentage reaches 99%, this is the part where things get a bit strange. At 99%, the percentage stops changing (it stays at 99%), and both the downloaded size and the total size increase together. For instance, using the previous scenario, we have:

99% (360MiB/360MiB)
99% (450MiB/450MiB)
.
.
.
99% (1.5GiB/1.5GiB)
.
.
.
99%(3.0GiB/3.0GiB)
.
.
Finished

This goes on all the way until the download is finished. Those values in the example are made-up, but they are there to illustrate describe the basic gist of ClipGrab's current behavior.

Here's a screenshot of me downloading a video that is about 8GiB in size.
2022-12-17-134854_680x232_scrot

Obviously, the progress information is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant