Skip to content

Update add video to playlist prompt to show presence count when adding 2+ videos #4818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PikachuEXE wants to merge 2 commits into from
Closed

Update add video to playlist prompt to show presence count when adding 2+ videos #4818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05307af
* Update add video ot playlist prompt to show presence count when add…
PikachuEXE Jan 16, 2024
cf06607
* Show no. of to be added videos count in text too
PikachuEXE Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/renderer/components/ft-playlist-selector/ft-playlist-selector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,33 @@ export default defineComponent({
count: this.loneVideoPresenceCountInPlaylist,
})
},
multiVideoPresenceCountInPlaylist() {
if (this.toBeAddedToPlaylistVideoList.length < 2) { return null }

// Count of to be added videos already present in this playlist
const v = this.toBeAddedToPlaylistVideoList.reduce((accumulator, toBeAddedToVideo) => {
return this.playlist.videos.some((pv) => pv.videoId === toBeAddedToVideo.videoId)
? accumulator + 1
: accumulator
}, 0)
// Don't display zero value
return v === 0 ? null : v
},
multiVideoPresenceCountInPlaylistText() {
if (this.multiVideoPresenceCountInPlaylist == null) { return null }

return this.$tc('User Playlists.AddVideoPrompt.{videoCount}/{totalVideoCount} Videos Already Added', this.multiVideoPresenceCountInPlaylist, {
videoCount: this.multiVideoPresenceCountInPlaylist,
totalVideoCount: this.toBeAddedToPlaylistVideoList.length,
})
},
videoPresenceCountInPlaylistText() {
return this.loneVideoPresenceCountInPlaylistText ?? this.multiVideoPresenceCountInPlaylistText
},
videoPresenceCountInPlaylistTextVisible() {
if (!this.videoPresenceCountInPlaylistTextShouldBeVisible) { return false }

return this.loneVideoPresenceCountInPlaylistText != null
return this.videoPresenceCountInPlaylistText != null
},
},
created: function () {
Expand Down
2 changes: 1 addition & 1 deletion src/renderer/components/ft-playlist-selector/ft-playlist-selector.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
v-if="videoPresenceCountInPlaylistTextVisible"
class="videoPresenceCount"
>
{{ loneVideoPresenceCountInPlaylistText }}
{{ videoPresenceCountInPlaylistText }}
</div>
</div>
</div>
Expand Down
1 change: 1 addition & 0 deletions static/locales/en-US.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ User Playlists:
Save: Save

Added {count} Times: 'Added {count} Time | Added {count} Times'
"{videoCount}/{totalVideoCount} Videos Already Added": '{videoCount}/{totalVideoCount} Video Already Added | {videoCount}/{totalVideoCount} Videos Already Added'

Toast:
You haven't selected any playlist yet.: You haven't selected any playlist yet.
Expand Down