Accessibility Improvements #1525
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -42,6 +42,8 @@ | |||
| "rebuild:electron": "electron-builder install-app-deps", | ||||
| "rebuild:node": "npm rebuild", | ||||
| "release": "run-s test build", | ||||
| "test": "run-s rebuild:node pack:workers jest", | ||||
|
Member
There was a problem hiding this comment.
Suggested change
|
||||
| "test:watch": "run-s rebuild:node pack:workers jest:watch", | ||||
|
Member
There was a problem hiding this comment.
Suggested change
|
||||
| "ci": "yarn install --frozen-lockfile" | ||||
| }, | ||||
| "dependencies": { | ||||
|
|
@@ -104,6 +106,8 @@ | |||
| "eslint-plugin-promise": "^5.1.0", | ||||
| "eslint-plugin-standard": "^5.0.0", | ||||
| "eslint-plugin-vue": "^7.17.0", | ||||
| "eslint-plugin-vuejs-accessibility": "^1.2.0", | ||||
| "fast-glob": "^3.2.7", | ||||
|
Member
There was a problem hiding this comment. a newer version of fast-glob is available. also curious as to why this package is added? is it needed by vuejs-accessibility?
Member
There was a problem hiding this comment.
Suggested change
|
||||
| "file-loader": "^6.2.0", | ||||
| "html-webpack-plugin": "^5.3.2", | ||||
| "mini-css-extract-plugin": "^2.2.2", | ||||
|
|
||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,44 +65,56 @@ export default Vue.extend({ | |
| methods: { | ||
| toggleDropdown: function () { | ||
| const dropdownBox = $(`#${this.id}`) | ||
| if (this.dropdownShown) { | ||
| dropdownBox[0].style.display = 'none' | ||
| this.dropdownShown = false | ||
| return | ||
| } | ||
|
|
||
| dropdownBox[0].style.display = 'inline' | ||
| this.dropdownShown = true | ||
|
|
||
| const firstItem = dropdownBox.find('.listItem')[0] | ||
| if (firstItem) { | ||
| firstItem.tabindex = 0 | ||
| firstItem.setAttribute('aria-selected', 'true') | ||
| dropdownBox.attr('aria-expanded', 'true') | ||
| firstItem.focus() | ||
| } | ||
|
|
||
| dropdownBox.on('focusout', (e) => { | ||
| if (dropdownBox.has(e.relatedTarget).length) { | ||
| return | ||
| } | ||
|
|
||
| dropdownBox[0].style.display = 'none' | ||
| dropdownBox.attr('aria-expanded', 'false') | ||
|
|
||
| const shareLinks = dropdownBox.find('.shareLinks') | ||
| if (shareLinks.length > 0) { | ||
| if (!shareLinks[0].parentNode.matches(':hover')) { | ||
| dropdownBox.get(0).style.display = 'none' | ||
| // When pressing the profile button | ||
| // It will make the menu reappear if we set `dropdownShown` immediately | ||
| setTimeout(() => { | ||
| this.dropdownShown = false | ||
| }, 100) | ||
| } | ||
| } else { | ||
| dropdownBox.get(0).style.display = 'none' | ||
| // When pressing the profile button | ||
| // It will make the menu reappear if we set `dropdownShown` immediately | ||
| setTimeout(() => { | ||
| this.dropdownShown = false | ||
| }, 100) | ||
| } | ||
| }) | ||
| }, | ||
|
|
||
| focusOut: function() { | ||
| const dropdownBox = $(`#${this.id}`) | ||
| dropdownBox.trigger('focusout') | ||
| dropdownBox[0].style.display = 'none' | ||
| this.dropdownShown = false | ||
| }, | ||
|
|
||
|
|
@@ -114,7 +126,19 @@ export default Vue.extend({ | |
| } | ||
| }, | ||
|
|
||
| handleDropdownClick: function ({ url, index }, event) { | ||
| if (!this.$handleDropdownKeyboardEvent(event, event?.target)) { | ||
| return | ||
| } | ||
|
|
||
| // const listbox = $(`#${this.id}`) | ||
| // const allOptions = listbox.children() | ||
|
|
||
| // allOptions.attr('aria-selected', 'false') | ||
| // allOptions.attr('tabindex', '-1') | ||
| // event.target.setAttribute('aria-selected', 'true') | ||
| // event.target.setAttribute('tabindex', '0') | ||
|
Comment on lines
+134
to
+140
Member
There was a problem hiding this comment. What happen to this commented code?
Collaborator
Author
There was a problem hiding this comment. This was a temporary removal - will add it back when I have the time.
Member
There was a problem hiding this comment. @jasonhenriquez would you be able to provide context on the removal? maybe someone else could work on it. (I think this is the main blocker for the code to be reviewed) |
||
|
|
||
| if (this.returnIndex) { | ||
| this.$emit('click', index) | ||
| } else { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.