Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript incomptibilities after #55 #81

Open
gemdav opened this issue Jun 5, 2024 · 0 comments
Open

Javascript incomptibilities after #55 #81

gemdav opened this issue Jun 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@gemdav
Copy link
Contributor

gemdav commented Jun 5, 2024

🐞 Bug Report

Describe the Bug

Since #55, I have compatibility issues between the generated JavaScript code and Outlook on Windows as a target. As OfficeJS Add-Ins are particularly hard to debug, the reason for this is still unknown. The problem is event handler code in Microsoft Office Add-in code not being executed properly.

Due to parallels to this thread, there is a chance that the problems come from JS standard version incompatibilities.
Microsoft claims that Outlook Add-ins support the ES2016 (ES7 for short) standard. The default compilation target of the KotlinJS compiler is ES5 (source). Thus, usually, the generated code should be supported due to downwards compatibility.

Nonetheless, I managed to resolve the issue by reverting #55.

Update: events are also triggered in Debug mode which is another parallel to this thread.

To Reproduce

I have not yet been able to check if there are problems with environments other that Outlook on Windows clients. As such, this is really laborious to reproduce as it requires developing an OfficeJS Add-In. After the event based OfficeJS Add-in is developed, event handlers will only be invoked with #55 reverted.

Expected Behavior

I expect the generated JS code to work exactly the same with and without #55.

System Information

  • Component: watermarker
  • Runtime: OfficeJS

Additional Context

@gemdav gemdav added the bug Something isn't working label Jun 5, 2024
@gemdav gemdav changed the title ES2016 incomptibilities after #55 Javascript incomptibilities after #55 Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant