Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust usage of Pako library once Kotlin Bug is fixed #22

Open
hnorkowski opened this issue Mar 25, 2024 · 0 comments
Open

Adjust usage of Pako library once Kotlin Bug is fixed #22

hnorkowski opened this issue Mar 25, 2024 · 0 comments
Assignees
@hnorkowski
Labels
bug Something isn't working component: watermarker Watermarker Library dependencies Software dependencies on hold Further work is currently on hold or blocked by external factors

Comments

@hnorkowski
Copy link
Contributor

🐞 Bug Report

Describe the Bug

The current implementation of the watermarker library has a workaround implemented to prevent a crash caused by a bug in Kotlin. This workaround should be removed once the bug is fixed in Kotlin.

Additional Context

Adjust the usage of the Pako library in jsMain/kotlin/helper/Compression.kt as follows as soon as this bug is fixed:

  • The functions in the external object Pako should change:

    • fun deflateRaw(data: IntArray, options: Any? = definedExternally): IntArray ->
      fun deflateRaw(data: UByteArray, options: Any? = definedExternally): UByteArray

    • fun inflateRaw(data: IntArray, options: Any? = definedExternally): IntArray ->
      fun inflateRaw(data: UByteArray, options: Any? = definedExternally): UByteArray

  • The functions Compression.{inflate, deflate} must be changed accordingly
@hnorkowski hnorkowski added the bug Something isn't working label Mar 25, 2024
@hnorkowski hnorkowski self-assigned this Mar 25, 2024
@hnorkowski hnorkowski added component: watermarker Watermarker Library dependencies Software dependencies labels Mar 25, 2024
@mhellmeier mhellmeier added the on hold Further work is currently on hold or blocked by external factors label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hnorkowski hnorkowski

Labels
bug Something isn't working component: watermarker Watermarker Library dependencies Software dependencies on hold Further work is currently on hold or blocked by external factors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhellmeier @hnorkowski