-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add columns support to Single overload #289
Comments
This is definitely (or almost definitely, see last para below...) a breaking change. The obvious new method signature is It appears at first that something even worse would happen, namely that Despite all that, it would still actually be possible to support a |
The version of
Single()
at line 509 of Massive.Shared.cs with signaturepublic virtual dynamic Single(string where, params object[] args)
does not support acolumns
argument.This would actually be very useful to have. I think so because I needed it in the project I'm working on, and added it for myself and used it a lot, and I think so because
All()
supports columns, and the other explicit version ofSingle()
supports columns, and all the rather cryptic variants ofSingle()
which are dynamically supported byTryInvokeMember
supportcolumns
.It's easy to add an optional
columns
param, with default value*
to this method (which is what I did), and this would link against existing code, but I think from your contribution guidelines it should be added as another new method.The text was updated successfully, but these errors were encountered: