Algorand.Crypto.KeyPair(byte[] privateKey) constructor bug

[oysterpack]

public KeyPair(byte[] privateKey)
{
    if (privateKey.Length != SK_SIZE)
        throw new ArgumentException("Incorrect private key length");

    ClearTextPrivateKey= privateKey;

    ed25519PrivateKey = new Ed25519PrivateKeyParameters(ClearTextPrivateKey, 0);
    ed25519PublicKey = ed25519PrivateKey.GeneratePublicKey();
    Pair = new AsymmetricCipherKeyPair(ed25519PrivateKey, ed25519PublicKey); // BUG - parameters are specified in the wrong order - public key comes first
}

The fix is a 1-line code change:

Pair = new AsymmetricCipherKeyPair(ed25519PublicKey, ed25519PrivateKey); 

Simple unit test to reproduce the issue:

[Fact]
public void NewKeyPairFromPrivateKey()
{
    var keyPair1 = new KeyPair(SecureRandom.GetInstance("SHA256PRNG"));
    var keyPair2 = new KeyPair(keyPair1.ClearTextPrivateKey); // THROWS EXCEPTION
    Assert.Equal(keyPair1.ToMnemonic(), keyPair2.ToMnemonic());
}

The above unit test fails with the following exception thrown:

System.ArgumentException: Expected a public key (Parameter 'publicParameter')

System.ArgumentException
Expected a public key (Parameter 'publicParameter')
   at Org.BouncyCastle.Crypto.AsymmetricCipherKeyPair..ctor(AsymmetricKeyParameter publicParameter, AsymmetricKeyParameter privateParameter)
   at Algorand.Crypto.KeyPair..ctor(Byte[] privateKey)

[FrankSzendzielarz]

OK thx will implement this fix shortly. Strange that I overlooked or didn't receive this notification until now.