Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version number in hospital-user icon #17435

Closed
7 tasks done
tagliala opened this issue Nov 25, 2020 · 3 comments
Closed
7 tasks done

Wrong version number in hospital-user icon #17435

tagliala opened this issue Nov 25, 2020 · 3 comments
Assignees
Labels

Comments

@tagliala
Copy link
Member

Describe the bug
hospital-user has the wrong version number, because it can't be used with FA 5.7.0. It happened because of 5.13.0 release, in which we moved some existing pro icons to the free set.

To Reproduce

  1. https://fontawesome.com/icons/hospital-user?style=solid
  2. Check the version number (5.7.0)
  3. Try to use hospital-user in 5.7.0

Expected behavior
Has correct version number

Screenshots
n/a

Version and implementation
Version: < 5.13
Browser and version: n/a

  • SVG with JS
  • Web Fonts with CSS
  • SVG Sprites
  • On the Desktop

Bug report checklist

  • I have filled out as much of the above information as I can
  • I have included a test case because my odds go way up that the team can fix this when I do
  • I have searched for existing issues and to the best of my knowledge this is not a duplicate
@talbs
Copy link
Member

talbs commented Jul 29, 2021

@tagliala, sorry for the radio slience on this one. It looks like we corrected the version number associated with hospital-user - https://github.com/FortAwesome/fontawesome-buildsystem/blob/5.x/icons/icons.yml#L19508. I've tested out referencing this icon with a kit running Font Awesome 5.7.0 and all seems well - https://codepen.io/fontawesome/pen/mdmLdpq.

Let us know if this doesn't seem resolved to you. We'll re-open and fa-wrestle it down to the ground.

@talbs talbs closed this as completed Jul 29, 2021
@tagliala
Copy link
Member Author

Hi @talbs maybe I was not clear that I was referring to the free set

Try to use hospital-user in 5.7.0 edit: in FA Free

When we released 5.13.0, the one with COVID icons, we moved some icons from the pro set to the free set

One of those icons is fa-hospital-user, that can be used with FA 5 free starting from version 5.13.0 (but not with 5.7.0)

Since:

  • docs are related to both versions
  • we do not have a distinction between fa-pro version and fa-free version
  • the solid icon does not have a "Pro" label because it is now part of the free set

I've asked to change the "updated" to version 5.13.0, so free users know that if they want to use that icon, they should update to 5.13.0

@sensibleworld
Copy link
Member

@tagliala Thanks for the clarification! I've got a fix up for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants
@talbs @sensibleworld @tagliala and others