This repository was archived by the owner on Feb 19, 2022. It is now read-only.
Send request to webpack-dev-server before starting tests #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev/spec-setup.js
Outdated
| var SERVER_HOST = "127.0.0.1"; | ||
| var SERVER_PORT = "3000"; | ||
| var DEV_SERVER_TIMEOUT = 20000; | ||
| var DEV_SERVER_TIMEOUT = process.env.TEST_FUNC_DEV_SERVER_TIMEOUT || 20000; |
Member
There was a problem hiding this comment.
GLOBAL: Prefer npm config style variables that can be overridden either by env or by package.json:config
See https://github.com/FormidableLabs/builder#npm-config
The result would be something (and sorry it's long) like:
var DEV_SERVER_TIMEOUT = process.env.npm_package_config_test_func_dev_server_timeout || 20000;
Contributor
Author
|
@ryan-roemer Updated all the configuration to take advantage of npm config. Thanks for all the feedback! |
dev/spec-setup.js
Outdated
| port: SERVER_PORT, | ||
| path: BASE_DIR + "/" | ||
| }, function () { | ||
| cb(); |
Member
There was a problem hiding this comment.
Should we capture / respond to errors here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.