Improvement: add gitee and jsdelivr resource url #371
Conversation
|
@nooop3 I like this as a temporary solution, but it doesn't close #369 since I've made that about creating an offline fallback option so that it covers wider issues of network access. It does need some more work though so that it better integrates into the script; will do a more thorough review this weekend. |
|
@Foggalong Yes, you are right. This is a temporary solution. And I only added the |
|
@nooop3 For sure, you did the right thing bumping the date! And yeah as discovered over there the plan is to add that kind of fallback :) |
Original change by @nooop3 had it assigned as an environment variable, but probably more useful to have them directly checked as fallbacks. This also sets up the infrastructure to have the local version as the ultimate fallback.
|
Updated your code to make those fallbacks available directly through the script rather than as env variables. Thanks so much for getting the ball rolling on this 😄 |
To resolve the GitHub access issue in some regions, I added a new environment variable
HARDCODE_FIXER_SOURCE, which can set togiteeandjsdelivrand default isgithub. Can temporarily address #369 until the fallback is added.