Make the Store able to subscribe to Action publishers (#85)

Author: MortenGregersen

Sources/Fluxor/Store.swift

@@ -203,16 +203,34 @@ public extension Store where Environment == Void {
     }
 }
 
+// MARK: - Subscriptions
+
+extension Store: Subscriber {
+    public typealias Input = Action
+    public typealias Failure = Never
+
+    public func receive(subscription: Subscription) {
+        subscription.request(.unlimited)
+    }
+
+    public func receive(_ input: Action) -> Subscribers.Demand {
+        dispatch(action: input)
+        return .unlimited
+    }
+
+    public func receive(completion: Subscribers.Completion<Never>) {}
+}
+
 // MARK: - Private
 
-extension Store {
+private extension Store {
     /**
      Creates `Cancellable`s for the given `Effect`s.
 
      - Parameter effects: The `Effect`s to create `Cancellable`s for
      - Returns: The `Cancellable`s for the given `Effect`s
      */
-    private func createCancellables(for effects: [Effect<Environment>]) -> [AnyCancellable] {
+    func createCancellables(for effects: [Effect<Environment>]) -> [AnyCancellable] {
         return effects.map(createCancellable(for:))
     }
 
@@ -222,7 +240,7 @@ extension Store {
      - Parameter effect: The `Effect` to create `Cancellable` for
      - Returns: The `Cancellable` for the given `Effect`
      */
-    private func createCancellable(for effect: Effect<Environment>) -> AnyCancellable {
+    func createCancellable(for effect: Effect<Environment>) -> AnyCancellable {
         switch effect {
         case .dispatchingOne(let effectCreator):
             return effectCreator(actions.eraseToAnyPublisher(), environment)

Tests/FluxorTests/StoreTests.swift

@@ -236,21 +236,22 @@ class StoreTests: XCTestCase {
         wait(for: [VoidTestEffects.expectation], timeout: 5)
     }
 
-    /// Can we get all state changes in a `MockStore`?
-    func testMockStoreStateChanges() {
+    /// Does the `Store` dispatch actions when it subscribes to a `Publisher`?
+    func testSubscribing() {
         // Given
-        let mockStore = MockStore(initialState: TestState(type: .initial, lastAction: nil))
+        let subject = PassthroughSubject<Action, Never>()
+        let interceptor = TestInterceptor<TestState>()
+        let store = Store(initialState: TestState(type: .initial))
+        store.register(interceptor: interceptor)
+        subject.subscribe(store)
+        XCTAssertEqual(interceptor.stateChanges.count, 0)
         let action = TestAction()
-        let modifiedState = TestState(type: .modified, lastAction: "Set State")
         // When
-        mockStore.dispatch(action: action)
-        mockStore.setState(newState: modifiedState)
+        subject.send(action)
+        subject.send(completion: .finished)
         // Then
-        XCTAssertEqual(mockStore.stateChanges.count, 2)
-        XCTAssertEqual(mockStore.stateChanges[0].action as! TestAction, action)
-        let setStateAction = mockStore.stateChanges[1].action as! AnonymousAction<TestState>
-        XCTAssertEqual(setStateAction.id, "Set State")
-        XCTAssertEqual(mockStore.stateChanges[1].newState, modifiedState)
+        XCTAssertEqual(interceptor.stateChanges.count, 1)
+        XCTAssertEqual(interceptor.stateChanges[0].action as! TestAction, action)
     }
 }