Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove markdown from dependencies #206

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

longemen3000
Copy link
Contributor

@longemen3000 longemen3000 commented Jul 16, 2024

At first glance, seems that Markdown is being loaded but not used in the package.
this PR was done in the context of JuliaFolds2/Transducers.jl#35

@cstjean cstjean merged commit 9a66349 into FluxML:master Jul 16, 2024
10 checks passed
@cstjean
Copy link
Collaborator

cstjean commented Jul 16, 2024

I merged, but does this really make a difference?

"""
    Markdown

Tools for working with the Markdown markup language for formatted text, used within Julia for documentation.
The `Markdown` module provides the (internal) [`MD`](@ref) type as well as the string
literals `md"..."` and `doc"..."`.
"""

Feels like this is loaded no matter what, no? It's an stdlib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants