Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Great Cat Issue #252

Closed
MikeInnes opened this issue May 1, 2018 · 5 comments
Closed

The Great Cat Issue #252

MikeInnes opened this issue May 1, 2018 · 5 comments

Comments

@MikeInnes
Copy link
Member

Recording all the PRs I have on this in one place – #156, #184, #243, #194. Will have to merge all of these in some way.

Also issue #213.
@gustafsson
Copy link
Contributor

Worth to mention: JuliaLang/julia#20815

@gustafsson
Copy link
Contributor

I had a go at merging these into #243.

I added tests from the different PRs and issues as well as the implementation of cat(dims, x...) from #156

@MikeInnes
Copy link
Member Author

Ok, that's great! Could you credit the PR authors in the commit for that, and I'll take a look at merging?

@gustafsson
Copy link
Contributor

Done! Thanks for the link about co-authorship

@MikeInnes
Copy link
Member Author

#243 is merged including everyone's work -- thanks @gustafsson!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gustafsson @MikeInnes