Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskDataset does not sub-type MLUtils.AbstractDataContainer #252

Open
darsnack opened this issue Jul 25, 2022 · 3 comments
Open

TaskDataset does not sub-type MLUtils.AbstractDataContainer #252

darsnack opened this issue Jul 25, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Contributions welcome!

Comments

@darsnack
Copy link
Member

I would sub-type MLUtils.AbstractDataContainer to get some sensible defaults like Base.iterate defined on top of the MLUtils.jl interface.

@lorenzoh
Copy link
Member

That’s a good idea!

@lorenzoh lorenzoh added enhancement New feature or request good first issue Good for newcomers help wanted Contributions welcome! labels Jul 27, 2022
@dfarmer
Copy link

dfarmer commented Jan 19, 2023

I like the package and was hoping to contribute. This one seems like a pretty easy place to start. As far as code goes I guess it's trivial? (I'm new to Julia, though not to programming so maybe I'm wrong here).

struct TaskDataset{TData, TTask <: LearningTask, TContext <: Context} <: MLUtils.AbstractDataContainer
    data::TData
    task::TTask
    context::TContext
end

But I was trying to figure out what tests I can add. I see MLUtils defines Base.size, Base.iterate, and Base.lastindex but I'm having a little trouble in FastAI.jl figuring out the right place to put the tests (seems like most of them are in the implementation file, but I didn't see any in taskdata.jl) and I was having a little trouble figuring out a quick and easy way to instantiate a test TaskDataset. If you're busy then no worries I'll just keep poking around until I figure it out but I'd glady take any tips too.

@lorenzoh
Copy link
Member

Yep, it should be a simple change. Happy to see contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Contributions welcome!
Projects
None yet
Development

No branches or pull requests

3 participants