Skip to content

Detect URL and install using Plugin Manager #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 28, 2021
Merged

Detect URL and install using Plugin Manager #823

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
092b459
Detect URL and install
Garulf Nov 18, 2021
8c50d13
Use correct icon
Garulf Nov 18, 2021
cf056a9
Filename as title for result
Garulf Nov 18, 2021
2e2d259
Block install if manual install exists
Garulf Nov 19, 2021
9940539
add plugin installation notifications
jjw24 Nov 20, 2021
73c1031
append new guid as zip and file name, update error messaging
jjw24 Nov 20, 2021
4eeaaec
fix naming when installed from url source
jjw24 Nov 20, 2021
a796ac4
add capability to only load unique plugins with the highest version
jjw24 Nov 20, 2021
ebf9ef1
add check downloaded plugin zip has same or lesser version
jjw24 Nov 21, 2021
a07252c
add ability to switch off warning when unknown source
jjw24 Nov 21, 2021
c7e77e3
add tests for loading unique metadata method
jjw24 Nov 21, 2021
7868d62
update test
jjw24 Nov 21, 2021
48c0f21
only msg plugin download & install succes/failure
jjw24 Nov 22, 2021
76efdfc
version bump PluginsManager
jjw24 Nov 22, 2021
2edc345
Fix or condition
Garulf Nov 24, 2021
ea179e5
shorten version compare logic
jjw24 Nov 28, 2021
07aebae
Merge branch 'dev' into install-from-url
jjw24 Nov 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,8 +555,8 @@ private bool SameOrLesserPluginVersionExists(string metadataPath)
var newMetadata = JsonSerializer.Deserialize<PluginMetadata>(File.ReadAllText(metadataPath));
return Context.API.GetAllPlugins()
.Any(x => x.Metadata.ID == newMetadata.ID
&& (x.Metadata.Version == newMetadata.Version)
|| newMetadata.Version.CompareTo(x.Metadata.Version) < 0);
&& (x.Metadata.Version == newMetadata.Version
|| newMetadata.Version.CompareTo(x.Metadata.Version) < 0));
}
}
}