Skip to content

add initial ShellRun support for JsonRPC #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 28, 2021
Merged

add initial ShellRun support for JsonRPC #742

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d41dd78
add initial ShellRun support for JsonRPC
shedric1 Oct 9, 2021
ae7de8d
refactor to use ShellCommand
jjw24 Nov 17, 2021
a6ddaf9
Merge branch 'dev' into JsonRPCShellRun
jjw24 Nov 17, 2021
02d101a
fix formatting
jjw24 Nov 17, 2021
3e38a90
version bump plugins
jjw24 Nov 17, 2021
ef56d91
add filename param to ShellRun command for running other shell types
jjw24 Nov 17, 2021
8cf9390
update comment
jjw24 Nov 17, 2021
a7ef589
update StartInfo arguments if cmd shell type
jjw24 Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ public interface IPublicAPI
/// </summary>
void RestartApp();

/// <summary>
/// Run a shell command or external program
/// </summary>
/// <param name="cmd">The command or program to run</param>
void ShellRun(string cmd);

/// <summary>
/// Save everything, all of Flow Launcher and plugins' data and settings
/// </summary>
Expand Down
10 changes: 10 additions & 0 deletions Flow.Launcher/PublicAPIInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,16 @@ public void OpenSettingDialog()
});
}

public void ShellRun(string cmd)
{
System.Diagnostics.Process process = new();
var startInfo = process.StartInfo;
startInfo.FileName = "cmd.exe";
startInfo.Arguments = $"/C {cmd}";
startInfo.CreateNoWindow = true;
process.Start();
Copy link
Member

@jjw24 jjw24 Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spedrickson have you tested this with your plugin? the method is not returning the result from the command

Copy link
Author

@spedrickson spedrickson Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it works for my plugin, but I'm only using it to launch files (identical to Browser plugin), not receive data back on the plugin side.

One concern with returning results: right now the commands are launched in a separate process to prevent locking up the Flow UI, so even long-running commands won't impact user experience. Maintaining a list of running processes is easy enough, but then we get into design decisions like whether return order should be maintained.

Might be worth adding a separate function like GetShellRun ,that works the same way but keeps the process and regularly polls it for output?

}

public void StartLoadingBar() => _mainVM.ProgressBarVisibility = Visibility.Visible;

public void StopLoadingBar() => _mainVM.ProgressBarVisibility = Visibility.Collapsed;
Expand Down