Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the bottomsheet listview is short, you can drag the sheet misplaced. #80

Closed
molikto opened this issue Nov 6, 2015 · 3 comments
Closed
Labels

Comments

@molikto
Copy link

molikto commented Nov 6, 2015

1 pic

@ZacSweers ZacSweers added the bug label Nov 9, 2015
@ZacSweers
Copy link
Contributor

I've seen this before as well, not sure how to repro it though. Any suggestions?

@molikto
Copy link
Author

molikto commented Nov 9, 2015

https://www.youtube.com/watch?v=HjNkzglZTPE&feature=youtu.be

This is how i repro it.

@bert-mccutchen
Copy link

In BottomSheetLayout.java :: expandSheet() function:

ObjectAnimator anim = ObjectAnimator.ofFloat(this, SHEET_TRANSLATION, getHeight());

Should be replaced with:

ObjectAnimator anim = ObjectAnimator.ofFloat(this, SHEET_TRANSLATION, getMaxSheetTranslation());

This will prevent the sheet from filling the full height of the view and limit its height to the content (if it is smaller) when expandSheet() is called from anywhere in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants