-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'bob' performance discussion #6
Comments
This looks amazing and super-promising. What should be the next step? |
/cc @addaleax :-) |
I have updated the project's progress as of today, some next steps and status are listed there: #5 :D |
Hm, is there anything specific I can provide to this discussion? Overall I’m still somewhat unsure about the general approach, and I don’t see anywhere where suggestions for API or implementation changes have been made on a conceptual level, but if anybody has something they’d like me to take a look at I’d be happy to. |
@addaleax ... mainly want to just keep you in the loop about the activity here. I know you've got other things you're looking at so no worries at all if you don't have the time to actively follow the work :-) |
So, I finally profiled this on my linux box (macOS is useless because of
___channel_get_opt
, good luck).I have documented the results so far in
performance.md
. I only really tried doing a very large file and have not yet made cases that make many small streams.The results are looking good. The HDD is the limiting factor of my linux system, and the profiles show file copying has ~7x less CPU time in JS, and zlib transform has ~33% less CPU time in JS. 💥 (C++ time does not seem significantly affected for either case.)
cc @jasnell, @mcollina
The text was updated successfully, but these errors were encountered: