Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the authorization to active/inactive contracts is not within the scope of x/wasmplus or not #48

Closed
da1suk8 opened this issue May 10, 2023 · 1 comment
Assignees

Comments

@da1suk8
Copy link
Member

da1suk8 commented May 10, 2023

This issue related to #43

Check the x/wasmplus authority for active/inactive specifications.

@da1suk8 da1suk8 self-assigned this May 10, 2023
@da1suk8
Copy link
Member Author

da1suk8 commented May 15, 2023

I have investigated this test and found that in Finschia/finschia-sdk#625, UpdateContractStatus(), which managed active/inactive list, was removed, and then in Finschia/finschia-sdk#655, the handling of active/inactive list was changed to be done in wasm module.

By Finschia/finschia-sdk#625, UpdateContractStatusProposal is removed (Finschia/finschia-sdk#625 (comment)), and by Finschia/finschia-sdk#655, GenesisState’s inactive_contract_addresses is used to manage active/inactive

// InactiveContractAddresses is a list of contract address that set inactive
repeated string inactive_contract_addresses = 6 [(gogoproto.jsontag) = "inactive_contract_address,omitempty"];

@da1suk8 da1suk8 closed this as completed May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant