Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detaching the custom wasm proto part of lbm-sdk #623

Closed
4 tasks
zemyblue opened this issue Aug 2, 2022 · 0 comments · Fixed by #625 or #661
Closed
4 tasks

Detaching the custom wasm proto part of lbm-sdk #623

zemyblue opened this issue Aug 2, 2022 · 0 comments · Fixed by #625 or #661
Assignees
Labels

Comments

@zemyblue
Copy link
Member

zemyblue commented Aug 2, 2022

Summary

Modify cosmwasm/wasm proto files in proto directory to be same as cosmwasm/wasmd(https://github.com/CosmWasm/wasmd/tree/main/proto/cosmwasm/wasm/v1)
And detaching custom wasm's proto part.

Problem Definition

We changed x/wasm's proto path from #617 to the same as cosmwasm/wasmd's proto path.
StoreCodeAndInstantiateContract tx is not exist in original cosmwasm/wasmd's path, but it exists in wasm proto. https://github.com/line/lbm-sdk/blob/9ba6ea37c656a09697e49f81a62e78326f0455f0/proto/cosmwasm/wasm/v1/tx.proto#L18-L19
This causes compatibility issues with cosmwasm/wasmd.

So we need to detaching lbm-sdk's custom wasm proto part including StoreCodeAndInstantiateContract.

Proposal

  1. detaching StoreCodeAndInstantiateContract from wasm's tx.proto.

  2. replace contract blacklist function

  • Rollback ContractInfo struct of wasm's type.proto to origin.
  • remove ContractStatus of ContractInfo.
  • make new genesis proto in lbm/wasm/v1. this genesis is similar with wasmd's genesis, but add the black list function instead of ContractStatue of ContractInfo struct.
  1. add the proposals to add or remove contract black list.

  2. add contract black list query API.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment