fix(button): multiple file selection not possible after first batch selected

fixes #1287

Author: Ray Nicholus

client/js/button.js

@@ -147,7 +147,7 @@ qq.UploadButton = function(o) {
         },
 
         setMultiple: function(isMultiple, opt_input) {
-            var input = this.getInput() || opt_input;
+            var input = opt_input || this.getInput();
 
             // Temporary workaround for bug in in iOS8 UIWebView that causes the browser to crash
             // before the file chooser appears if the file input doesn't contain a multiple attribute.
@@ -178,6 +178,7 @@ qq.UploadButton = function(o) {
             }
 
             qq(options.element).removeClass(options.focusClass);
+            input = null;
             input = createInput();
         }
     });

test/unit/button.js

@@ -29,15 +29,17 @@ describe("button.js", function () {
         $fixture.append("<div id='foo'></div>");
 
         var button = new qq.UploadButton({
-            element: $fixture.find("#foo")[0]
+            element: $fixture.find("#foo")[0],
+            multiple: true,
+            ios8BrowserCrashWorkaround: false
         });
 
         var input = button.getInput();
-        var $input = $(input);
 
         button.reset();
-        assert.notEqual($input[0], button.getInput(),
+        assert.notEqual(input, button.getInput(),
                "resetting the button should clear the element from the DOM");
+        assert.ok(qq(button.getInput()).hasAttribute("multiple"), "the multiple attribute should be added to new button after reset");
     });
 
     it("does add an internal tracker ID to the input button, and re-adds it on reset", function() {