Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS2AiOS Violates the ios naming standard #29

Closed
dev-at-webid-solutions-dot-de opened this issue Jun 28, 2024 · 1 comment
Closed

XS2AiOS Violates the ios naming standard #29

dev-at-webid-solutions-dot-de opened this issue Jun 28, 2024 · 1 comment

Comments

@dev-at-webid-solutions-dot-de

XS2A is not using an iOS naming standard (swiftlang/swift#43510) since the module and the main public class have the same name. So to solve the problem of this dependency, we propose that you distribute it to us embedded within your framework, thus guaranteeing compatibility and avoiding problems like Shadowed Name and the crashes when a xcframework try to use it.

It would be great, if you could deliver a version 2.0.0 of your XS2AiOS, in which the class XS2AiOS and all it usages (other code-references, documentatoin, etc.) was renamed to e.g. XS2A

@fritzfelix
Copy link
Collaborator

Fixed by #30. Thank you for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants