Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDP Methods should take in extra data #56

Closed
ZenGround0 opened this issue Oct 12, 2024 · 2 comments · Fixed by #78
Closed

PDP Methods should take in extra data #56

ZenGround0 opened this issue Oct 12, 2024 · 2 comments · Fixed by #78
Assignees

Comments

@ZenGround0
Copy link
Contributor

The PDP Listener interface should allow an extra data param to be threaded through from the caller. This means we should add extra data params into the main PDP interface to allow caller to talk directly to the listener. This lets us use the safer, cleaner listener pattern but still allow for protocol extensions in base PDP that allow offchain auth and other extensions. The canonical example is an application that allows PDP client to fully determine the allowlist of valid cids to be added to proofset.

  1. Without extra data: in this case the PDP client must go to the application contract directly and store the valid cids that are allowed to be added to the proofset in the contract state before the PDP SP can call PDP addroots.
  2. With extra data: signature is sent to PDP SP who then includes it and passes to listener during addRoots call
@ZenGround0
Copy link
Contributor Author

ZenGround0 commented Oct 12, 2024

Note: this is the approach we used for DDO. Though this time I think one extra data per call is fine, no need to have an array per individual operation in a batch

@magik6k
Copy link

magik6k commented Oct 13, 2024

Makes sense, definitely at least for the non-prove calls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants