feat: terminate all data set rails (storange and CDN) atomically #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
reviewed
Jul 25, 2025
Kubuxu
approved these changes
Jul 25, 2025
github-project-automation
bot
moved this from 🔎 Awaiting review
to ✔️ Approved by reviewer
in FS
juliangruber
requested changes
Jul 25, 2025
github-project-automation
bot
moved this from ✔️ Approved by reviewer
to ⌨️ In Progress
in FS
juliangruber
approved these changes
Jul 28, 2025
| // Burn one-time fee to register | ||
| require(msg.value == SP_REGISTRATION_FEE, "Incorrect registration fee"); | ||
| (bool sent, ) = BURN_ADDRESS.call{value: msg.value}(""); | ||
| (bool sent,) = BURN_ADDRESS.call{value: msg.value}(""); |
Collaborator
Author
There was a problem hiding this comment.
Just a forge fmt
| }); | ||
| } | ||
|
|
||
| function railTerminated(uint256 railId, address terminator, uint256 endEpoch) external override { |
Member
There was a problem hiding this comment.
For my understanding: After terminateDataSetPayment, this method will now be called up to three times for one data set, once per payment rail. The first call will change the state paymentEndEpoch = endEpoch, the other two calls will be noops and safe to ignore. Right?
github-project-automation
bot
moved this from ⌨️ In Progress
to ✔️ Approved by reviewer
in FS
juliangruber
changed the title
Closed
DarkLord017
pushed a commit
to DarkLord017/filecoin-services
that referenced
this pull request
Oct 8, 2025
…Ozone#93) Clients & SPs should now call `terminateDataSetPayment` on the service contract to terminate the payment rails for their dataset atomically. The service contract will revert the `railTerminated` callback from the Payments contract if the rail terminator is not the service contract itself. Piece removal is allowed after the payment is terminated for a dataset but piece addition is not as increasing the rate of a terminated rail is not allowed by the payments contract. Once the dataset is beyond it's payment end epoch, all operations other than ownership change and dataset deletion are reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients & SPs should now call
terminateDataSetPaymenton the service contract to terminate the payment rails for their dataset atomically. The service contract will revert therailTerminatedcallback from the Payments contract if the rail terminator is not the service contract itself.Piece removal is allowed after the payment is terminated for a dataset but piece addition is not as increasing the rate of a terminated rail is not allowed by the payments contract.
Once the dataset is beyond it's payment end epoch, all operations other than ownership change and dataset deletion are reverted.