You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sorry if this isn't very clear, but I spent a couple of hours digging in the code and the issues, and maybe I don't have the full picture of the problem.
When I set wrapInSafeArea to false, the bottomOffset is still being set and this cause a visual issue (keyboard to close to the Composer). Manually setting bottomOffset to 0 doesn't work, but that is going to be fixed in the next release, due to this PR. (right now I had to set it to 1 as a workaround). Side note: I found wrapInSafeAreaPR just by coincidence, because isn't in the documentation.
Steps to Reproduce / Code Snippets
Set wrapInSafeArea={false}
Open chat keyboard
Result IOS:
Expected Results
If wrapInSafeArea is false, react-native-iphone-x-helpergetBottomSpace don't need to be called in safeAreaSupport.
result:
Additional Information
Nodejs version: 12.18.1
React version: 16.9.43
React Native version: 0.61.4
react-native-gifted-chat version: 0.16.3
Platform(s) (iOS, Android, or both?): both
The text was updated successfully, but these errors were encountered:
matias91
changed the title
Avoid "bottomOffset" when wrapInSafeArea"
Avoid "bottomOffset" when "wrapInSafeArea" is false
Jul 13, 2020
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Issue Description
Sorry if this isn't very clear, but I spent a couple of hours digging in the code and the issues, and maybe I don't have the full picture of the problem.
When I set wrapInSafeArea to false, the bottomOffset is still being set and this cause a visual issue (keyboard to close to the Composer). Manually setting bottomOffset to 0 doesn't work, but that is going to be fixed in the next release, due to this PR. (right now I had to set it to 1 as a workaround).
Side note: I found
wrapInSafeArea
PR just by coincidence, because isn't in the documentation.Steps to Reproduce / Code Snippets
wrapInSafeArea={false}
Expected Results
If wrapInSafeArea is false,
react-native-iphone-x-helper
getBottomSpace don't need to be called in safeAreaSupport.result:
Additional Information
The text was updated successfully, but these errors were encountered: