Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid "bottomOffset" when "wrapInSafeArea" is false #1870

Closed
matias91 opened this issue Jul 13, 2020 · 2 comments
Closed

Avoid "bottomOffset" when "wrapInSafeArea" is false #1870

matias91 opened this issue Jul 13, 2020 · 2 comments
Labels

Comments

@matias91
Copy link

matias91 commented Jul 13, 2020

Issue Description

Sorry if this isn't very clear, but I spent a couple of hours digging in the code and the issues, and maybe I don't have the full picture of the problem.
When I set wrapInSafeArea to false, the bottomOffset is still being set and this cause a visual issue (keyboard to close to the Composer). Manually setting bottomOffset to 0 doesn't work, but that is going to be fixed in the next release, due to this PR. (right now I had to set it to 1 as a workaround).
Side note: I found wrapInSafeArea PR just by coincidence, because isn't in the documentation.

Steps to Reproduce / Code Snippets

  • Set wrapInSafeArea={false}
  • Open chat keyboard
  • Result IOS:
    IMG_3621

Expected Results

If wrapInSafeArea is false, react-native-iphone-x-helper getBottomSpace don't need to be called in safeAreaSupport.

result:
IMG_3622

Additional Information

  • Nodejs version: 12.18.1
  • React version: 16.9.43
  • React Native version: 0.61.4
  • react-native-gifted-chat version: 0.16.3
  • Platform(s) (iOS, Android, or both?): both
@matias91 matias91 changed the title Avoid "bottomOffset" when wrapInSafeArea" Avoid "bottomOffset" when "wrapInSafeArea" is false Jul 13, 2020
@matias91
Copy link
Author

Posted 14 days ago. Any suggestion/comments about this?

@stale
Copy link

stale bot commented Aug 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 27, 2020
@stale stale bot closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant