Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the code work with Python 3 + latest Selenium #7

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Make the code work with Python 3 + latest Selenium #7

merged 2 commits into from
Oct 24, 2022

Conversation

ppasupat
Copy link
Collaborator

  • Converted to Python3 using 2to3 + some manual fixes.
  • Modified the code to work with the latest Chrome and Selenium. Tested with pytest as instructed in python/README.md.

Test environment: Ubuntu 22.04 / Python 3.10.6 + virtualenv / Chrome 106 / Selenium API v4.5.0

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit a96675b into Farama-Foundation:master Oct 24, 2022
@ppasupat ppasupat deleted the python3 branch October 24, 2022 23:04
@WentseChen WentseChen mentioned this pull request Nov 20, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppasupat @pseudo-rnd-thoughts