-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ActionSpaceConfig #25
Added ActionSpaceConfig #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, I just have a question on if the functions should be methods or just functions
miniwob/action.py
Outdated
raise ValueError(f"Unknown preset name {name}") | ||
|
||
|
||
def get_action_space(config: ActionSpaceConfig) -> spaces.Space: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want get_action_space
and get_raw_coords
as ActionSpaceConfig
methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have moved the methods to ActionSpaceConfig.
@@ -2,6 +2,7 @@ | |||
|
|||
include = [ | |||
"miniwob/**", | |||
"tests/**", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be including tests
in the release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added that line to trigger pyright on presubmit. Is there a different way to trigger pyright on tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I thought this line was for the files that are included in the release.
You are correct, this is the correct way of adding tests to pyright.
Though I should note that we normally don't care about having correct type hints for the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It still helps with catching mistakes like missing method arguments, so I would prefer to keep it here for now.
Description
Added ActionSpaceConfig for custom action spaces.
Fixes #26.
Type of change
Please delete options that are not relevant.
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)