Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed drag-circle task name + Use gymnasium API in tests. #21

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

ppasupat
Copy link
Collaborator

Description

  • Consolidated drag-item and drag-circle task names.
  • Made the tests use gymnasium.make(...) instead of MiniWoBEnvironment(...).
  • Turned off threading in the Selenium instance handler (used for running multiple Selenium instances, but we removed that functionality).

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ppasupat ppasupat mentioned this pull request Feb 13, 2023
10 tasks
@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit e7829de into Farama-Foundation:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants