Unpin cmake dependency and remove wheel. #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pseudo-rnd-thoughts
approved these changes
Dec 4, 2023
pseudo-rnd-thoughts
merged commit fd6ddc1
into
Farama-Foundation:master
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In nixpkgs, we'd like to build using newer versions of CMake. If nothing is known to be broken in later versions, would it be possible to relax this constraint?
Separately, I have removed the wheel dependency, as it is not explicitly needed. When a PEP 517 compliant build frontend invokes setuptools to build a wheel, it'll ask setuptools if it needs any additional dependencies, and setuptools will indicate it needs wheel (through the get-requires-for-build-wheel hook).