Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeding mechanism breaks in DEBUG builds #468

Open
dreavjr opened this issue Aug 29, 2022 · 1 comment
Open

Seeding mechanism breaks in DEBUG builds #468

dreavjr opened this issue Aug 29, 2022 · 1 comment

Comments

@dreavjr
Copy link

dreavjr commented Aug 29, 2022

In environment.py, in AtariEnv.seed, the seed is converted to a signed integer, with the expectation that it will be reconverted into an unsigned integer inside stella_environment.

That only works in Release builds. In Debug builds, an assertion aborts execution when seed <= 0. That makes Debug builds unusable for development with Python.

@JesseFarebro
Copy link
Collaborator

Hi @dreavjr,

Good catch, this is annoying on debug builds. I'll circle back to this and hopefully fix it for the next release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants