Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Asyncio Instead of Threads #23

Open
kb1lqc opened this issue Jan 23, 2018 · 0 comments
Open

Implement Asyncio Instead of Threads #23

kb1lqc opened this issue Jan 23, 2018 · 0 comments

Comments

@kb1lqc
Copy link
Member

kb1lqc commented Jan 23, 2018

There's no reason this needs to be threaded to properly check and send TUN packets. asyncio, pytest-asyncio, and pyserial-asyncio should be able to handle this very well. I previously tried to implement asyncio into the TUN adapter but it did not work out well. I was mainly hindered by the inability to test it since I want to maintain as much Test Driven Development as possible.

Timeline

This is not absolutely imperative but it would be a good idea to include it in before we get too far along. For now threads will likely work. This issue ticket is a good reminder that we should move towards newer technology when possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant