Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rf.c TX/RX Buffer Sizing Inconsistant #71

Open
kb1lqd opened this issue Mar 13, 2017 · 0 comments
Open

rf.c TX/RX Buffer Sizing Inconsistant #71

kb1lqd opened this issue Mar 13, 2017 · 0 comments

Comments

@kb1lqd
Copy link
Contributor

kb1lqd commented Mar 13, 2017

As noted in #4 the buffer/FIFO sizing is inconsistent and likely buggy/non-optimal and is difficult to understand. Thank you

#Updates Needed

  • The buffer sizes should be optimized for the largest expected packets
  • The buffer sizing should be easy to follow and all functions/buffers/etc... must use defined lengths

Baseline Summary

DEFINES:
TX_PACKET_LEN 61
RX_PACKET_LEN 61
RX_PKT_HANDLE_APPEND_LEN 2
RF_DATALINK_PACKET_PAYLOAD_LEN 62
RF_DATALINK_PACKET_RX_FOOTER_LEN 2

Variables:
tx_buffer[62];

FIFOS:
rf_datalink_tx_fifo_buffer[RF_DATALINK_PACKET_PAYLOAD_LEN*RF_DATALINK_PACKET_FIFO_COUNT] = 62*x bytes
rf_datalink_rx_fifo_buffer[(RF_DATALINK_PACKET_PAYLOAD_LEN+RF_DATALINK_PACKET_RX_FOOTER_LEN)*RF_DATALINK_PACKET_FIFO_COUNT] = 64*x bytes

Functions:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant