tx_buffer Variable Unneded

[kb1lqd]

In rf.c the variable tx_buffer[] was defined as a global variable and was moved into the only function that used it when documenting the code. Inspection shows that this buffer is only used as a copy to then again copy into the Transmit() function. The tx_buffer[] operations could be completely removed likely and directly copy into the Transmit() function.

void radio_tx(unsigned char *buffer, unsigned char buffer_len){
    unsigned char tx_buffer[62];
    unsigned char i;
    //BUG: Doesn't check for buffer size too long...
    for(i=0;i<buffer_len;i++){
        tx_buffer[i] = buffer[i];
    }
    for(i=buffer_len;i<TX_PACKET_LEN;i++){
        tx_buffer[i] = 0xff;
    }

    Transmit((unsigned char *)tx_buffer, TX_PACKET_LEN);

}