rf_tx_datalink_packet() Incorrect Declaration

[kb1lqd]

During documentation I found that this function in the header file was incorrectly defined as:

unsigned char rf_tx_datalink_packet(char *src_callsign, unsigned char src_callsign_len, unsigned char src_callsign_id, char *dest_callsign, unsigned char dest_callsign_len, unsigned char dest_callsign_id, unsigned char dest_callsign_id, unsigned char packet_config, unsigned char payload_len, unsigned char *payload);

which is incorrect (dest_callsign_id repeated in the packet_type argument location) and should be:

unsigned char rf_tx_datalink_packet(char *src_callsign, unsigned char src_callsign_len, unsigned char src_callsign_id, char *dest_callsign, unsigned char dest_callsign_len, unsigned char dest_callsign_id, unsigned char packet_type, unsigned char packet_config, unsigned char payload_len, unsigned char *payload);

The source file was correctly defined:

unsigned char rf_tx_datalink_packet(char *src_callsign, unsigned char src_callsign_len, unsigned char src_callsign_id, char *dest_callsign, unsigned char dest_callsign_len, unsigned char dest_callsign_id, unsigned char packet_type, unsigned char packet_config, unsigned char payload_len, unsigned char *payload)

This was not previously caught because RF protocol currently only implements a single packet so no checking is performed. The bug results in unknown data in the packet ID (likely the destination callsign ID).