Skip to content

Commit

Permalink
Simplify and cleanup CSS and improve initial load performance (#147)
Browse files Browse the repository at this point in the history
* Adding custom modern CSS reset and removing minireset as dependency

* Simplifying CSS to be smaller and more performant

* Keep prettier for css files

* Very minor size reductions

* Lazy load tagify CSS

* Remove CSS map file

* Minor style adjustments to results

* Add changelog

---------

Co-authored-by: Simon Heimler <[email protected]>
  • Loading branch information
Fannon and Simon Heimler authored Oct 26, 2024
1 parent 3de976f commit eb95eeb
Show file tree
Hide file tree
Showing 14 changed files with 299 additions and 292 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## [unreleased]

- **IMPROVED**: Performance of CSS initial load
- Cleaned up and simplified CSS
- Lazy load CSS necessary for bookmark tagging and options view

## [v1.10.3]

- **FIXED**: Deleting a bookmark via popup accidentally removed all bookmarks from index (temporarily)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,8 @@ This extension makes use of the following helpful open-source projects (thanks!)
- https://github.com/yairEO/tagify for the tag autocomplete widget
- https://markjs.io/ for highlighting search matches
- https://www.npmjs.com/package/js-yaml for the user options parsing
- https://github.com/jgthms/minireset.css for some minimal CSS base styling
- https://github.com/tabler/tabler-icons for icons
- https://www.joshwcomeau.com/css/custom-css-reset/

## Feedback and Ideas

Expand Down
1 change: 0 additions & 1 deletion bin/updateLibs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,3 @@ cat node_modules/mark.js/dist/mark.es6.min.js >> popup/lib/mark.es6.min.js
cp node_modules/js-yaml/dist/js-yaml.min.js popup/lib/js-yaml.min.js
cp node_modules/\@yaireo/tagify/dist/tagify.js popup/lib/tagify.min.js
cp node_modules/\@yaireo/tagify/dist/tagify.css popup/lib/tagify.min.css
cp node_modules/minireset.css/minireset.min.css popup/lib/minireset.min.css
1 change: 1 addition & 0 deletions bin/updateManifests.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable no-console */
import fs from 'fs'

const packageJson = JSON.parse(fs.readFileSync('package.json').toString())
Expand Down
167 changes: 76 additions & 91 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit eb95eeb

Please sign in to comment.