Fix open URL not working when there are multiple windows (#113)

* Fix open url not working when there are multiple windows * Adding changelog entry * Bump version to 1.9.5 --------- Co-authored-by: Simon Heimler <[email protected]>
Fannon · Dec 14, 2023 · b74546c · b74546c
1 parent 596c844
commit b74546c
Show file tree

Hide file tree

Showing 7 changed files with 85 additions and 78 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,13 @@
 
 ## [unreleased]
 
+## [v1.9.5]
+
+- **FIXED**: Open result in new tab (when holding SHIFT / ALT) was not working when there are multiple browser windows
+  - Reported in [#111](https://github.com/Fannon/search-bookmarks-history-and-tabs/discussions/111) and [#112](https://github.com/Fannon/search-bookmarks-history-and-tabs/issues/112)
+
+## [v1.9.4]
+
 - **NEW**: Added option `bookmarksIgnoreFolderList`, that excludes all bookmarks from the search that are within the listed folder(s)
   - This includes sub-folders and their bookmarks
 

diff --git a/README.md b/README.md
@@ -13,7 +13,7 @@
 
 **This extension does not collect any data nor does it make any external requests** (see [Privacy](#privacy--data-protection)).
 
-It supports three different search approaches:
+It supports two different search approaches:
 
 - **Exact search** (case-insensitive, but exact matching): Faster, but only exact matching results.
 - **Fuzzy search** (approximate matching): Slower, but includes also inexact (fuzzy) matches.
@@ -29,23 +29,6 @@ For a list of recent changes, see [CHANGELOG.md](./CHANGELOG.md).
 
 ![Demo Animation](/images/bookmark-and-history-search.gif 'Demo Animation')
 
-## Privacy / Data Protection
-
-This extension is built to respect your privacy:
-
-- It does not have permissions for outside communication, so none of your data is shared or exposed externally.
-- The extension does not even store any information except your user settings.
-  Every time the extension popup is closed, it "forgets" everything and starts from a blank slate next time you open it.
-- There is no background job / processing. If the popup is not explicitly opened by the user, the extension is not executed.
-- The extension only requests the following permissions for the given reasons:
-  - **bookmarks**: Necessary to read and edit the bookmarks. Can be disabled via [user configuration](#user-configuration).
-  - **history**: Necessary to read the browsing history. Can be disabled or limited via [user configuration](#user-configuration).
-  - **tabs**: Necessary to find open tabs and to use tabs for navigation. Can be disabled via [user configuration](#user-configuration).
-  - **storage**: Necessary to store and retrieve the [user configuration](#user-configuration).
-    If the browser has setting synchronization enabled, the extension settings will be synced (in this case you already trust your browser to sync everything else anyway).
-    If browser sync is disabled, the user configuration is only stored locally.
-- The extension is open source, so feel free to convince yourself :)
-
 ## User Documentation
 
 - **Search Strategies**: Switch between precise and fuzzy approach by clicking on the FUZZY or PRECISE button in the search bar (top right).
@@ -168,6 +151,23 @@ The scoring systems works roughly the following:
 
 For a description of the scoring options and what they do, please see [popup/js/model/options.js](popup/js/model/options.js).
 
+## Privacy / Data Protection
+
+This extension is built to respect your privacy:
+
+- It does not have permissions for outside communication, so none of your data is shared or exposed externally.
+- The extension does not even store any information except your user settings.
+  Every time the extension popup is closed, it "forgets" everything and starts from a blank slate next time you open it.
+- There is no background job / processing. If the popup is not explicitly opened by the user, the extension is not executed.
+- The extension only requests the following permissions for the given reasons:
+  - **bookmarks**: Necessary to read and edit the bookmarks. Can be disabled via [user configuration](#user-configuration).
+  - **history**: Necessary to read the browsing history. Can be disabled or limited via [user configuration](#user-configuration).
+  - **tabs**: Necessary to find open tabs and to use tabs for navigation. Can be disabled via [user configuration](#user-configuration).
+  - **storage**: Necessary to store and retrieve the [user configuration](#user-configuration).
+    If the browser has setting synchronization enabled, the extension settings will be synced (in this case you already trust your browser to sync everything else anyway).
+    If browser sync is disabled, the user configuration is only stored locally.
+- The extension is open source, so feel free to convince yourself :)
+
 ## Local Development
 
 ### Install and Build
@@ -199,7 +199,6 @@ The built extensions can be found
   - Enable "Developer mode"
   - Choose "Load unpacked" and open the root folder of this repository
 - **For Firefox**:
-
   - First [install and build](#install-and-build) this project.
   - Load the built extension in `dist/firefox` as a temporary addon in `about:debugging`.
 

diff --git a/manifest.firefox.json b/manifest.firefox.json
@@ -3,7 +3,7 @@
   "description": "Browser extension to (fuzzy) search and navigate bookmarks, history and open tabs.",
   "homepage_url": "https://github.com/Fannon/search-bookmarks-history-and-tabs",
   "author": "Simon Heimler",
-  "version": "1.9.4",
+  "version": "1.9.5",
   "manifest_version": 2,
   "applications": {
     "gecko": {

diff --git a/manifest.json b/manifest.json
@@ -3,7 +3,7 @@
   "description": "Browser extension to (fuzzy) search and navigate bookmarks, history and open tabs.",
   "homepage_url": "https://github.com/Fannon/search-bookmarks-history-and-tabs",
   "author": "Simon Heimler",
-  "version": "1.9.4",
+  "version": "1.9.5",
   "manifest_version": 3,
   "permissions": ["tabs", "bookmarks", "history", "storage"],
   "action": {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,23 +1,23 @@
 {
   "name": "search-bookmarks-history-and-tabs",
-  "version": "1.9.4",
+  "version": "1.9.5",
   "description": "Browser extension to (fuzzy) search and navigate bookmarks, history and open tabs.",
   "main": "index.js",
   "dependencies": {
-    "@leeoniya/ufuzzy": "^1.0.11",
+    "@leeoniya/ufuzzy": "^1.0.13",
     "@yaireo/tagify": "^4.17.9",
     "bulma": "^0.9.4",
     "js-yaml": "^4.1.0",
     "mark.js": "^8.11.1"
   },
   "devDependencies": {
-    "cypress": "^13.5.1",
+    "cypress": "^13.6.1",
     "cypress-fail-on-console-error": "^5.0.3",
-    "eslint": "^8.53.0",
-    "eslint-config-prettier": "^9.0.0",
+    "eslint": "^8.55.0",
+    "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-cypress": "^2.15.1",
     "live-server": "^1.2.2",
-    "prettier": "3.1.0",
+    "prettier": "3.1.1",
     "prettier-eslint": "^16.1.2",
     "sass": "^1.69.5"
   },

diff --git a/popup/js/view/searchView.js b/popup/js/view/searchView.js
@@ -304,6 +304,7 @@ export function openResultItem(event) {
       ext.browserApi.tabs
         .query({
           active: true,
+          currentWindow: true,
         })
         .then(([currentTab]) => {
           ext.browserApi.tabs.update(currentTab.id, {