Fix linking & unlinking with npc

Author: OliverSchlueter

plugin/src/main/java/de/oliver/fancyholograms/FancyHologramsManager.java

@@ -206,8 +206,9 @@ public void syncHologramWithNpc(@NotNull final Hologram hologram) {
 
         npc.getData().setDisplayName("<empty>");
         npc.getData().setShowInTab(false);
+        npc.updateForAll();
 
-        final var location = npc.getData().getLocation().clone().add(0, npc.getEyeHeight(), 0);
+        final var location = npc.getData().getLocation().clone().add(0, npc.getEyeHeight() + 0.5, 0);
         hologram.getData().setLocation(location);
     }
 

plugin/src/main/java/de/oliver/fancyholograms/commands/HologramCMD.java

@@ -363,6 +363,14 @@ private boolean edit(@NotNull final Player player, @NotNull final Hologram holog
 
         if (action.equals("position")) {
             return editLocation(player, hologram, player.getLocation());
+        } else if (action.equals("unlinkwithnpc")) {
+            if (!FancyHologramsPlugin.isUsingFancyNpcs()) {
+                MessageHelper.warning(player, "You need to install the FancyNpcs plugin for this functionality to work");
+                MessageHelper.warning(player, "Download link: <click:open_url:'https://modrinth.com/plugin/fancynpcs/versions'><u>click here</u></click>.");
+                return false;
+            }
+
+            return editUnlinkWithNpc(player, hologram);
         }
 
         if (args.isEmpty()) {
@@ -576,15 +584,6 @@ private boolean edit(@NotNull final Player player, @NotNull final Hologram holog
 
                 yield editLinkWithNpc(player, hologram, args.remove(0));
             }
-            case "unlinkwithnpc" -> {
-                if (!FancyHologramsPlugin.isUsingFancyNpcs()) {
-                    MessageHelper.warning(player, "You need to install the FancyNpcs plugin for this functionality to work");
-                    MessageHelper.warning(player, "Download link: <click:open_url:'https://modrinth.com/plugin/fancynpcs/versions'><u>click here</u></click>.");
-                    yield false;
-                }
-
-                yield editUnlinkWithNpc(player, hologram);
-            }
             default -> false;
         };
     }

plugin/src/main/java/de/oliver/fancyholograms/listeners/NpcListener.java

@@ -46,7 +46,10 @@ public void onModify(@NotNull final NpcModifyEvent event) {
                             final var players = Bukkit.getOnlinePlayers();
 
                             needsToBeUpdated.forEach(this.plugin.getHologramsManager()::syncHologramWithNpc);
-                            needsToBeUpdated.forEach(hologram -> hologram.refreshHologram(players));
+                            needsToBeUpdated.forEach(hologram -> {
+                                hologram.updateHologram();
+                                hologram.refreshHologram(players);
+                            });
                         });
             }
             case DISPLAY_NAME, SHOW_IN_TAB -> {