Skip to content

Commit 21cfaaf

Browse files
committed
Fix UpdateSolutionFileContentSpecs not testing anything
1 parent 7526a71 commit 21cfaaf

4 files changed

Lines changed: 5 additions & 71 deletions

tests/Fallout.Cli.Specs/UpdateSolutionFileContentSpecs.Test_number=1.verified.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ VisualStudioVersion = 15.0.27703.2047
44
MinimumVisualStudioVersion = 10.0.40219.1
55
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "ConsoleApp1", "ConsoleApp1\ConsoleApp1.csproj", "{1992CC3B-CF32-485C-8DBC-77D0B6F18A82}"
66
EndProject
7-
Project("{KIND}") = "NAME", "RELATIVE", "{GUID}"
7+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "NAME", "RELATIVE", "{GUID}"
88
EndProject
99
Global
1010
GlobalSection(SolutionConfigurationPlatforms) = preSolution

tests/Fallout.Cli.Specs/UpdateSolutionFileContentSpecs.Test_number=2.verified.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
Microsoft Visual Studio Solution File, Format Version 12.00
2-
Project("{KIND}") = "NAME", "RELATIVE", "{GUID}"
2+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "NAME", "RELATIVE", "{GUID}"
33
EndProject
44
Global
55
GlobalSection(SolutionConfigurationPlatforms) = preSolution

tests/Fallout.Cli.Specs/UpdateSolutionFileContentSpecs.Test_number=3.verified.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
Microsoft Visual Studio Solution File, Format Version 12.00
2-
Project("{KIND}") = "NAME", "RELATIVE", "{GUID}"
2+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "NAME", "RELATIVE", "{GUID}"
33
EndProject
44
Global
55
GlobalSection(SolutionConfigurationPlatforms) = preSolution

tests/Fallout.Cli.Specs/UpdateSolutionFileContentSpecs.cs

Lines changed: 2 additions & 68 deletions
Original file line numberDiff line numberDiff line change
@@ -37,36 +37,6 @@ public class UpdateSolutionFileContentSpecs
3737
SolutionGuid = {61B2112A-2DA2-45AC-AFF5-6C50A10BB92F}
3838
EndGlobalSection
3939
EndGlobal
40-
""",
41-
"""
42-
Microsoft Visual Studio Solution File, Format Version 12.00
43-
# Visual Studio 15
44-
VisualStudioVersion = 15.0.27703.2047
45-
MinimumVisualStudioVersion = 10.0.40219.1
46-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "ConsoleApp1", "ConsoleApp1\ConsoleApp1.csproj", "{1992CC3B-CF32-485C-8DBC-77D0B6F18A82}"
47-
EndProject
48-
Project("{KIND}") = "NAME", "RELATIVE", "{GUID}"
49-
EndProject
50-
Global
51-
GlobalSection(SolutionConfigurationPlatforms) = preSolution
52-
Debug|Any CPU = Debug|Any CPU
53-
Release|Any CPU = Release|Any CPU
54-
EndGlobalSection
55-
GlobalSection(ProjectConfigurationPlatforms) = postSolution
56-
{GUID}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
57-
{GUID}.Release|Any CPU.ActiveCfg = Release|Any CPU
58-
{1992CC3B-CF32-485C-8DBC-77D0B6F18A82}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
59-
{1992CC3B-CF32-485C-8DBC-77D0B6F18A82}.Debug|Any CPU.Build.0 = Debug|Any CPU
60-
{1992CC3B-CF32-485C-8DBC-77D0B6F18A82}.Release|Any CPU.ActiveCfg = Release|Any CPU
61-
{1992CC3B-CF32-485C-8DBC-77D0B6F18A82}.Release|Any CPU.Build.0 = Release|Any CPU
62-
EndGlobalSection
63-
GlobalSection(SolutionProperties) = preSolution
64-
HideSolutionNode = FALSE
65-
EndGlobalSection
66-
GlobalSection(ExtensibilityGlobals) = postSolution
67-
SolutionGuid = {61B2112A-2DA2-45AC-AFF5-6C50A10BB92F}
68-
EndGlobalSection
69-
EndGlobal
7040
""")]
7141
[InlineData(
7242
2,
@@ -80,27 +50,6 @@ public class UpdateSolutionFileContentSpecs
8050
SolutionGuid = {77D83C53-98F5-4275-8217-14700BCA05BB}
8151
EndGlobalSection
8252
EndGlobal
83-
""",
84-
"""
85-
Microsoft Visual Studio Solution File, Format Version 12.00
86-
Project("{KIND}") = "NAME", "RELATIVE", "{GUID}"
87-
EndProject
88-
Global
89-
GlobalSection(SolutionConfigurationPlatforms) = preSolution
90-
Debug|Any CPU = Debug|Any CPU
91-
Release|Any CPU = Release|Any CPU
92-
EndGlobalSection
93-
GlobalSection(ProjectConfigurationPlatforms) = postSolution
94-
{GUID}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
95-
{GUID}.Release|Any CPU.ActiveCfg = Release|Any CPU
96-
EndGlobalSection
97-
GlobalSection(SolutionProperties) = preSolution
98-
HideSolutionNode = FALSE
99-
EndGlobalSection
100-
GlobalSection(ExtensibilityGlobals) = postSolution
101-
SolutionGuid = {77D83C53-98F5-4275-8217-14700BCA05BB}
102-
EndGlobalSection
103-
EndGlobal
10453
""")]
10554
[InlineData(
10655
3,
@@ -112,28 +61,13 @@ public class UpdateSolutionFileContentSpecs
11261
Release|Any CPU = Release|Any CPU
11362
EndGlobalSection
11463
EndGlobal
115-
""",
116-
"""
117-
Microsoft Visual Studio Solution File, Format Version 12.00
118-
Project("{KIND}") = "NAME", "RELATIVE", "{GUID}"
119-
EndProject
120-
Global
121-
GlobalSection(SolutionConfigurationPlatforms) = preSolution
122-
Debug|Any CPU = Debug|Any CPU
123-
Release|Any CPU = Release|Any CPU
124-
EndGlobalSection
125-
GlobalSection(ProjectConfigurationPlatforms) = postSolution
126-
{GUID}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
127-
{GUID}.Release|Any CPU.ActiveCfg = Release|Any CPU
128-
EndGlobalSection
129-
EndGlobal
13064
""")]
131-
public Task Test(int number, string input, string expected)
65+
public Task Test(int number, string input)
13266
{
13367
var content = input.SplitLineBreaks().ToList();
13468
Program.UpdateSolutionFileContent(content, "RELATIVE", "GUID", "NAME");
13569

136-
return Verifier.Verify(expected)
70+
return Verifier.Verify(string.Join(Environment.NewLine, content))
13771
.UseParameters(number);
13872
}
13973
}

0 commit comments

Comments
 (0)