Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom jellyfin password reset setting #565

Merged

Conversation

notquitenothing
Copy link
Contributor

@notquitenothing notquitenothing commented Nov 14, 2023

Description

Adding Jellyfin Setting for Custom "Forgot Password" URL. Useful in cases where you are using a custom authentication provider such as the Jellyfin LDAP plugin with Authelia. Authentik, lldap, or any other external auth scheme with its own password reset page.

I came across this idea in #212 (comment) , so thanks @Hani-K.
Even though this issue is marked as fixed, it didn't resolve my issue using Authelia to manage LDAP users through Jellyfin, where Jellyfin's password reset page doesn't work. Backwards compatible against existing settings files, and no change in existing password reset functionality if the setting is blank.

Screenshot (if UI-related)

image

To-Dos

  • Successful build yarn build

Issues Fixed or Closed

Adding Jellyfin Setting for Custom "Forgot Password" URL.  Useful in cases where you are using a custom authentication provider such as the LDAP plugin, Authelia, lldap, or any other external auth scheme with its own password reset page.
@fallenbagel
Copy link
Owner

fallenbagel commented Nov 14, 2023

Shouldn't this be merged when #184 is merged. Currently in develop it will go to external domain

@fallenbagel
Copy link
Owner

Oh wait this is for LDAP users right?

@notquitenothing
Copy link
Contributor Author

notquitenothing commented Nov 15, 2023

Yep, that other OIDC PR looks cool, but my use case is much simpler. This just lets me redirect users to my Authelia password reset page (which can send a password reset email for my LDAP users) instead of the non-functional Jellyfin password reset page. On the Jellyfin side I use custom CSS to hide the “Reset Password” option and provide password reset link to Authelia.

I know that setup, or similar ones using Authentik or LLDAP or manage LDAP users is pretty common, so I figure someone else would get some use out of this code change.

@fallenbagel
Copy link
Owner

Will take a look at this soon

@fallenbagel fallenbagel merged commit f8c4def into fallenbagel:develop Nov 30, 2023
6 checks passed
@fallenbagel
Copy link
Owner

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Jellyfin Password Reset
2 participants