Remove --overwrite flag from pacman command to install dependencies

[Elliot-TS]

When running oudedetai for the first time on Arch, it asks you to install the necessary dependencies with
pacman -Syu --overwrite \* --nocomfirm --needed

From the Arch Wiki:

Generally avoid using the --overwrite option with pacman. The --overwrite option takes an argument containing a glob. When used, pacman will bypass file conflict checks for files that match the glob. In a properly maintained system, it should only be used when explicitly recommended by the Arch Developers. See the #Read before upgrading the system section.

Is there any good reason for prompting the user to use the --overwrite flag? If the user has a properly maintained system, there should be no need for the --overwrite flag. And if their system is not properly maintained, then they probably have bigger issues they'll need to deal with.

[thw26]

Hey! Thanks for looking into this! We set up Arch's original command a while ago, so if there is a reason, I can't recall what it is for. Are you able to test this on your Arch machine by running from source? If not, we can test it but it will take us a little while to fire up the VM.

[Elliot-TS]

I could test it on my machine, although I haven't been able to get logos up and running on my machine yet. I've gotten it to install just fine, but I haven't gotten past downloading my logos resources yet. It just crashes when I tell it to download my resources. But I assume if I can get past the installer just fine, then that should be good enough to test installing the dependencies.

So far, I've manually run the install command without the --overwrite flag, and it works. I also saw that in the Utilities menu there was a button called Install Dependencies that attempted to run the command automatically (with --overwrite). But I think when I tried that, it didn't do anything. So I didn't know if that was working already or if the only way to install them currently is manually.

Are there any other places I should test to make sure removing the --overwrite flag doesn't break anything other than (1) when you hit "Install Logos" and it tells you to manually run the command to install the dependencies and (2) when you hit "Utilities -> Install Dependencies"?

[thw26]

Those should be the only two places. Everything that is called will reference the config setting. You could also try removing Arch from the list of bad/non-working OSes here to see if the installer works.

LogosLinuxInstaller/ou_dedetai/system.py

Line 608 in 8926435

if config.OS_NAME in ['fedora', 'arch']:

One way to test this is to add some package to the required packages to the line below. I usually use nano.

LogosLinuxInstaller/ou_dedetai/system.py

Lines 361 to 370 in 8926435

	config.PACKAGES = (
	"fuse2 " # appimages
	"binutils libwbclient samba wget " # wine
	"p7zip " # winetricks
	"openjpeg2 libxcomposite libxinerama " # display
	"ocl-icd vulkan-icd-loader " # hardware
	"alsa-plugins gst-plugins-base-libs libpulse openal " # audio
	"libva mpg123 v4l-utils " # video
	"libxslt sqlite " # misc
	)

Then you can just pacman -R nano to test again. All of these actions are still stored in the oudedetai.log, so you should be able to follow what the program is doing at its various stages.

We've noticed that some issues with the initial install are in the way the ICU data files are installed. In general what we have recommended is deleting the ICU data files in your Downloads directory, then running that step again (which should happen in the current release on starting ou dedetai).