-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RichTextFX with Java 11 ? #776
Comments
Yes, RichTextFX 0.9.x does run on Java 11 but you'll need to add the following to your main application's JAR manifest (or the equivalent to the java command line):
This won't be necessary when RichTextFX 0.10 is released (hopefully early next year 2019). |
@Jugen You think we can make this project modular :) I just jumped to Java 11 and learning about modularization . |
RichTextFX depends on ReactFX, Flowless, UndoFx, and WellbehavedFx which (according to this article) should also all be made at least explicit automatic modules (via a JAR manifest entry). If this can be done then RichTextFX can also become a module. At the very least there is a fat JAR (see manual download) that bundles all these dependencies together with RichTextFX which I think could easily be released as a module. |
I'm trying to build on my Mac running OpenJDK 11.0.1. When I run
|
@duncanmak use latest 5.X gradle. That might solve the issue. |
@Adyel I'm building using Gradle 5.1. I wonder if the issue is that the Gradle TestSets plugin needs updating.
|
I don't know why this works (I'm new to JDK11 and it's crazy modularization stuff) but here's the VM equivalent of Jugen's first reply. Or atleast, what I wrote to get my stuff to run. Someone please come correct me if it's wrong:
I literally only got this to work by throwing a bunch of different configurations at the wall until it finally ran lol |
Before read this, I apologize for my bad english.
I tried to add: I know I have to add opens javaFX.scene.text but I don't know how to do this without VM-Args Thanks |
my english too..... :) After trying long time I found this solution, not sure is the best:
-Add the vm arguments :
|
to use VirtualizedScrollPane and reactfx component,, add in your module-info.java :
|
At last I've released version 0.10.0 which is a multi-release jar that is still compatible with Java 8 but doesn't require any JVM arguments (like Note: this release is not modular and the JARs still need to be on the classpath. |
Excellent work, @Jugen . Thank you. A small gotcha/tip: If you bundle RichTextFX in an uberjar, make sure to add |
Thanks it helped me :-) |
The multi-release JAR still didn't work for me. But SkyAphid's answer did work. Thanks. |
Can we successfully run RichTextFX with Java 11 ? If not what steps we can take to make it happen ?
The text was updated successfully, but these errors were encountered: