You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When building a multi change with MultiChangeBuilder it may often occur that no actual changes will be registered (e.g. replace all function with no matching search results).
Either the MultiChangeBuilder should just ignore (i.e. noop) in such a case or at least provide API to allow it's caller to see if there are changes to commit.
Current Workarounds
At the moment one has to clumsily note if there are actual changes in the MultiChangeBuilder, e.g. like this:
I have no idea what the thinking is behind MultiChangeBuilder throwing IllegalStateException and it not rather being a noop as suggested. So I've submitted a PR adding a hasChanges() method, which will help.
Desired Feature
When building a multi change with MultiChangeBuilder it may often occur that no actual changes will be registered (e.g. replace all function with no matching search results).
Either the MultiChangeBuilder should just ignore (i.e. noop) in such a case or at least provide API to allow it's caller to see if there are changes to commit.
Current Workarounds
At the moment one has to clumsily note if there are actual changes in the MultiChangeBuilder, e.g. like this:
The text was updated successfully, but these errors were encountered: