Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug, ProjectRed]: Project Red Integration Timer Crash #151

Closed
Zoeyowo opened this issue Oct 19, 2021 · 8 comments
Closed

[Bug, ProjectRed]: Project Red Integration Timer Crash #151

Zoeyowo opened this issue Oct 19, 2021 · 8 comments
Assignees

Comments

@Zoeyowo
Copy link

Zoeyowo commented Oct 19, 2021

Modpack

FTB Oceanblock

Modpack version

1.3.0

Log Files

https://paste.feed-the-beast.com/view/b41d28af

Describe the bug

Some of the ProjectRed Integration item icons when rendered by a refined storage pattern seem to crash the game I think the item that crashed me this time was the Timer item

Steps to reproduce

Using a refined storage pattern grid, make a pattern of a ProjectRed Integration and make the item icon appear such as by holding shift or putting the pattern into a crafter.

Expected behaviour

The game not crashing

Screenshots

No response

Additional information

No response

@Zoeyowo Zoeyowo changed the title [Bug]: [Bug]: Project Red Integration Timer Crash Oct 19, 2021
@Raidobw2
Copy link
Contributor

Hi, can you try without Optifine?

Your game is crashing on a minecraft function net.minecraft.client.renderer.ItemRenderer which I highly doubt is bad code from the original game code.
Optifine modifies minecraft classes and we don't recommend it, since it can cause these kind of bugs.

If you happen to still have the error after removing Optifine, please post another crash log and we will gladly resolve the issue.

Otherwise, you can close this issue and/or report it to the Optifine issue tracker.

@Zoeyowo
Copy link
Author

Zoeyowo commented Oct 19, 2021

Crash seems to still occur even without optifine. Which is weird after you said to delete optifine I was like "Yeah that actually makes a lot of sense" but it seems to still be having the same error so idk what's happening 🤔

https://paste.feed-the-beast.com/view/d31fd56e

My knowledge of how to read crash reports are pretty slim so hopefully y'all can figure it out!

@Raidobw2
Copy link
Contributor

Yup that's totally valid now, thank you. That's indeed a bug. Don't autocraft it for now, until we can get some feedback from the RefinedStorage dev. I might need to make another issue on Project Red Integration's tracker, but I'll wait on feedback from RS before doing so/ or Sunekaer will do that part if he believes that to be linked.

refinedmods/refinedstorage#3110

Explanation for Sune in the bottom part of that issue if he needs it.

@Raidobw2 Raidobw2 added Mod Issue and removed state: Awaiting Reply A reply is awaited from a user. labels Oct 20, 2021
@Raidobw2
Copy link
Contributor

Not Refined Storage's fault apparently, it's Project Red Integration. Filed an issue on their side.
MrTJP/ProjectRed#1686

@Sunekaer Sunekaer added the state: Awaiting Mod Update Waiting on a new mod update to be released containing a fix label Oct 24, 2021
@Raidobw2 Raidobw2 added this to the Pending Third-Party Updates milestone Oct 26, 2021
@Raidobw2 Raidobw2 changed the title [Bug]: Project Red Integration Timer Crash [Bug, ProjectRed]: Project Red Integration Timer Crash Oct 26, 2021
@Raidobw2
Copy link
Contributor

ProjectRed Integration released an update with a fix to CurseForge. This will prevent future crashes, but the item still won't be rendered in the pattern. RefinedStorage needs to fix that part still (linked issue still above and opened).

@judos
Copy link

judos commented Nov 28, 2021

Had same issue, just checked ProjectRed was released but there's no update to FTB OceanBlock yet in 1.9.0 with the updated mod.
Changelog: https://feed-the-beast.com/modpack/ftb_oceanblock
RefinedStorage Ticket: refinedmods/refinedstorage#3110
ProjectRed Ticket: MrTJP/ProjectRed#1686

@Raidobw2
Copy link
Contributor

The mod was updated yes, but not with the patch it seems. It's not in their changelog, so we're waiting for the next update.
This is what the workaround should look like, a print instead of an exception:
image
This is how the code actually looks like in version 4.10.0 of Project Red Integration, throws an exception, not a print:
image
The original crash states a scala.MatchError exception, so this makes perfect sense and the version 4.10.0 does not contain the fix yet.
Therefore we have to wait for the next version.

@Raidobw2 Raidobw2 added state: Fixed ✔️ and removed state: Awaiting Mod Update Waiting on a new mod update to be released containing a fix labels Dec 10, 2021
@Raidobw2 Raidobw2 removed this from the Awaiting Third-Party Updates milestone Dec 10, 2021
@Raidobw2
Copy link
Contributor

Seems fixed in 1.10.1 with mod updates, works in a crafter too, no crashes:
pattern_example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants