Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from ClientConnection custom diagnostics/alerts to LSP diagnostics/alerts #23

Closed
klinvill opened this issue Jan 10, 2024 · 0 comments · Fixed by #42
Closed

Move from ClientConnection custom diagnostics/alerts to LSP diagnostics/alerts #23

klinvill opened this issue Jan 10, 2024 · 0 comments · Fixed by #42

Comments

@klinvill
Copy link
Contributor

This idea was raised in #20 (comment).

@gebner suggested:

While we're at it, we can also remove the custom diagnostics/alert notifications (since they're already in LSP). They should also start with $/, as per the spec.

This comment applied to the custom diagnostics and alert messages in the ClientConnection class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use standard LSP requests. FStarLang/fstar-vscode-assistant
1 participant
@klinvill