Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve loading of the settings.json file #309

Closed
mateusz-lichota opened this issue Aug 25, 2022 · 0 comments · Fixed by #314
Closed

Improve loading of the settings.json file #309

mateusz-lichota opened this issue Aug 25, 2022 · 0 comments · Fixed by #314
Labels
enhancement New feature or request

Comments

@mateusz-lichota
Copy link
Contributor

mateusz-lichota commented Aug 25, 2022

Currently, the path on which the program looks for settings.json is hard coded in relation to the user's home directory, which tends to cause confusion and is in general a bad practice. In the original AirSim repo this was fixed to allow looking for the settings.json in

  • the executable's folder
  • the current directory from which the executable is being launched
  • a path specified by the --settings command line argument
    or optionally passing the full content of the settings.json file as a string argument (e.g. --settings "{\"SettingsVersion\": 1.0, \"SimMode\": \"Car\"}" )

Those changes were introduced in microsoft/AirSim#715 and microsoft/AirSim#2668,
and we can make the same changes here with little effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant