staticd generating core sometime

[abdosi]

Description

Thread 1 (Thread 0x7f6a51e507c0 (LWP 62)):
#0 0x00007f6a521f2ebc in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#1 0x00007f6a521a3fb2 in raise () from /lib/x86_64-linux-gnu/libc.so.6
#2 0x00007f6a5242ffdc in core_handler (signo=11, siginfo=0x7ffc597b93f0, context=) at ../lib/sigevent.c:261
#3
#4 0x00007f6a5204948c in ?? () from /lib/x86_64-linux-gnu/libyang.so.2
#5 0x00007f6a5206666a in ?? () from /lib/x86_64-linux-gnu/libyang.so.2
#6 0x00007f6a5205a0a6 in ?? () from /lib/x86_64-linux-gnu/libyang.so.2
#7 0x00007f6a5205ead3 in ?? () from /lib/x86_64-linux-gnu/libyang.so.2
#8 0x00007f6a5205f343 in lyd_new_path () from /lib/x86_64-linux-gnu/libyang.so.2
#9 0x00007f6a5240e679 in nb_candidate_edit (candidate=0x55e2e1e5bb50, nb_node=nb_node@entry=0x55e2e1e7b4c0, operation=, xpath=xpath@entry=0x7ffc597ba2d0 "/frr-routing:routing/control-plane-protocols/control-plane-protocol[type='frr-staticd:staticd'][name='staticd'][vrf='default']/frr-staticd:staticd/route-list[prefix='2603:10e2:400::6/128'][afi-safi='f"..., previous=previous@entry=0x0, data=data@entry=0x55e2e1f7a7d0) at ../lib/northbound.c:666
#10 0x00007f6a52414f1f in nb_cli_apply_changes_internal (vty=0x55e2e1f043e0, xpath_base=0x7ffc597bc340 "/frr-routing:routing/control-plane-protocols/control-plane-protocol[type='frr-staticd:staticd'][name='staticd'][vrf='default']/frr-staticd:staticd/route-list[prefix='2603:10e2:400::6/128'][afi-safi='f"..., clear_pending=) at ../lib/northbound_cli.c:205
#11 0x00007f6a52415457 in nb_cli_apply_changes (vty=vty@entry=0x55e2e1f043e0, xpath_base_fmt=xpath_base_fmt@entry=0x55e2e0d95669 "%s") at ../lib/northbound_cli.c:266
#12 0x000055e2e0d7fe8d in static_route_nb_run (vty=vty@entry=0x55e2e1f043e0, args=args@entry=0x7ffc597be320) at ../staticd/static_vty.c:380
#13 0x000055e2e0d83fa6 in ipv6_route_address_interface_magic (bfd_profile=0x0, bfd_source_str=0x0, bfd_source=..., bfd_multi_hop=0x0, bfd=0x0, color_str=0x0, color=, onlink=0x0, nexthop_vrf=0x55e2e1f5e540 "default", table_str=0x0, table=, label=0x0, vrf=0x0, distance_str=0x0, distance=, tag_str=0x55e2e1f1a8d0 "2", tag=, ifname=0x55e2e1f79b10 "PortChannel46", gate_str=0x55e2e1f7a3c0 "2603:10e2:400:14::4", gate=..., from_str=0x0, from=0x7ffc597be3f0, prefix_str=0x55e2e1f5bfa0 "2603:10e2:400::6/128", prefix=0x7ffc597be3d0, no=0x0, argv=, argc=, vty=0x55e2e1f043e0, self=) at ../staticd/static_vty.c:970
#14 ipv6_route_address_interface (self=, vty=0x55e2e1f043e0, argc=, argv=) at ./staticd/static_vty_clippy.c:1328
#15 0x00007f6a523d4620 in cmd_execute_command_real (vline=vline@entry=0x55e2e1f6b9b0, vty=vty@entry=0x55e2e1f043e0, cmd=cmd@entry=0x0, up_level=up_level@entry=0, filter=FILTER_RELAXED) at ../lib/command.c:1000
#16 0x00007f6a523d497e in cmd_execute_command (vline=vline@entry=0x55e2e1f6b9b0, vty=vty@entry=0x55e2e1f043e0, cmd=cmd@entry=0x0, vtysh=vtysh@entry=0) at ../lib/command.c:1059
#17 0x00007f6a523d4c10 in cmd_execute (vty=vty@entry=0x55e2e1f043e0, cmd=cmd@entry=0x55e2e1f0ab30 "ipv6 route 2603:10e2:400::6/128 2603:10e2:400:14::4 PortChannel46 nexthop-vrf default tag 2\n", matched=matched@entry=0x0, vtysh=vtysh@entry=0) at ../lib/command.c:1227
#18 0x00007f6a52447257 in vty_command (vty=vty@entry=0x55e2e1f043e0, buf=0x55e2e1f0ab30 "ipv6 route 2603:10e2:400::6/128 2603:10e2:400:14::4 PortChannel46 nexthop-vrf default tag 2\n") at ../lib/vty.c:513
#19 0x00007f6a52447a24 in vty_execute (vty=vty@entry=0x55e2e1f043e0) at ../lib/vty.c:1276
#20 0x00007f6a5244ac78 in vtysh_read (thread=) at ../lib/vty.c:2175
#21 0x00007f6a52441f5d in thread_call (thread=thread@entry=0x7ffc597c0950) at ../lib/thread.c:1990
#22 0x00007f6a523fa378 in frr_run (master=0x55e2e1d8ce70) at ../lib/libfrr.c:1198
#23 0x000055e2e0d7dadf in main (argc=, argv=0x7ffc597c0c98, envp=) at ../staticd/static_main.c:176

Version

FRRouting 8.5.4 (svcstr2-xxxx-lc2-1) on Linux(6.1.0-22-2-amd64).
Copyright 1996-2005 Kunihiro Ishiguro, et al.
configured with:
    '--build=x86_64-linux-gnu' '--prefix=/usr' '--includedir=${prefix}/include' '--mandir=${prefix}/share/man' '--infodir=${prefix}/share/info' '--sysconfdir=/etc' '--localstatedir=/var' '--disable-option-checking' '--disable-silent-rules' '--libdir=${prefix}/lib/x86_64-linux-gnu' '--libexecdir=${prefix}/lib/x86_64-linux-gnu' '--disable-maintainer-mode' '--localstatedir=/var/run/frr' '--sbindir=/usr/lib/frr' '--sysconfdir=/etc/frr' '--with-vtysh-pager=/usr/bin/pager' '--libdir=/usr/lib/x86_64-linux-gnu/frr' '--with-moduledir=/usr/lib/x86_64-linux-gnu/frr/modules' '--disable-dependency-tracking' '--disable-rpki' '--disable-scripting' '--enable-pim6d' '--with-libpam' '--enable-doc' '--enable-doc-html' '--enable-snmp' '--enable-fpm' '--disable-protobuf' '--disable-zeromq' '--enable-ospfapi' '--enable-bgp-vnc' '--enable-multipath=256' '--enable-user=frr' '--enable-group=frr' '--enable-vty-group=frrvty' '--enable-configfile-mask=0640' '--enable-logfile-mask=0640' 'build_alias=x86_64-linux-gnu' 'PYTHON=python3'

How to reproduce

Thier is no fix way to reproduce this. We have seen this happening with SONiC using FRR not frquently but in some nightly run.

Expected behavior

We should not see core generation for staticd

Actual behavior

Core generation seen for staticd.

Additional context

No response

Checklist

• I have searched the open issues for this bug.
• I have not included sensitive information in this report.

[abdosi]

@ton31337 : Is it some known issue in staticd ?

[abdosi]

@choppsv1 wondering your recent fix can help this ?

[choppsv1]

My recent change to lyd_new_path2() probably wouldn't avoid a core being generated inside libyang unfortunately.