openfabric: removing loopback interface configuration errors out with "ISIS is not enabled"

[c-po]

Description

Removing OpenFabric configuration from loopback interface will bail out with an ISIS related error.
Most likely due to a copy/paste issue

ISIS is not enabled on circuit lo
% [OPEN_FABRIC] Unknown command: no  openfabric passive

Version

FRR stable/10.1 2708aaa

How to reproduce

Load this configuration into FRR:

sudo /usr/lib/frr/frr-reload.py --reload /home/cpo/openfabric.txt

$ cat /home/cpo/openfabric.txt
!
frr version 10.1.1
frr defaults traditional
hostname LR1.wue3
service integrated-vtysh-config
!
interface eth1
 ip router openfabric VyOS
 ipv6 router openfabric VyOS
exit
!
interface lo
 ip router openfabric VyOS
 openfabric passive
exit
!
router openfabric VyOS
 net 49.0001.1111.1111.1111.00
exit
!
end

Unload the configuration:

[email protected]# sudo /usr/lib/frr/frr-reload.py --reload /home/cpo/no-openfabric.txt
Failed to execute interface lo  no openfabric passive exit
"interface lo --  no openfabric passive -- exit" we failed to remove this command
ISIS is not enabled on circuit lo
% [OPEN_FABRIC] Unknown command:  no openfabric passive

$ cat /home/cpo/no-openfabric.txt
!
frr version 10.1.1
frr defaults traditional
hostname LR1.wue3
service integrated-vtysh-config
!
end

Expected behavior

No error

Actual behavior

LR2.wue3(config-if)# no  openfabric passive
ISIS is not enabled on circuit lo
% [OPEN_FABRIC] Unknown command: no  openfabric passive

Additional context

Despite the error https://github.com/FRRouting/frr/blob/stable/10.1/isisd/isis_vty_fabricd.c contains several calls to vty_out() that reference ISIS in the message, should most likely be replaced with PROTO_NAME definition as in:

DEFUN (no_isis_passive,
       no_isis_passive_cmd,
       "no " PROTO_NAME " passive",
       NO_STR
       PROTO_HELP
       "Configure the passive mode for interface\n")

Checklist

• I have searched the open issues for this bug.
• I have not included sensitive information in this report.